Title: [218359] trunk/Source/WebInspectorUI
- Revision
- 218359
- Author
- commit-qu...@webkit.org
- Date
- 2017-06-15 14:50:37 -0700 (Thu, 15 Jun 2017)
Log Message
Web Inspector: Search highlight doesn't show up in resources when paused
https://bugs.webkit.org/show_bug.cgi?id=173438
<rdar://problem/32800114>
Patch by Joseph Pecoraro <pecor...@apple.com> on 2017-06-15
Reviewed by Matt Baker.
* UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor.prototype.revealPosition.revealAndHighlightLine):
Previously we were bailing if executionLineNumber was NaN, which means that when
we were paused we were incorrectly disabling highlights in any resource that does
not have the active callframe. Relax this and make it match the intended behavior
of only disabling highlights if the highlight line matches the execution line.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (218358 => 218359)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-06-15 21:38:49 UTC (rev 218358)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-06-15 21:50:37 UTC (rev 218359)
@@ -1,5 +1,20 @@
2017-06-15 Joseph Pecoraro <pecor...@apple.com>
+ Web Inspector: Search highlight doesn't show up in resources when paused
+ https://bugs.webkit.org/show_bug.cgi?id=173438
+ <rdar://problem/32800114>
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/TextEditor.js:
+ (WebInspector.TextEditor.prototype.revealPosition.revealAndHighlightLine):
+ Previously we were bailing if executionLineNumber was NaN, which means that when
+ we were paused we were incorrectly disabling highlights in any resource that does
+ not have the active callframe. Relax this and make it match the intended behavior
+ of only disabling highlights if the highlight line matches the execution line.
+
+2017-06-15 Joseph Pecoraro <pecor...@apple.com>
+
Uncaught Exception: TypeError: null is not an object (evaluating 'this.contentBrowser.contentViewForRepresentedObject')
https://bugs.webkit.org/show_bug.cgi?id=173425
<rdar://problem/32744172>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js (218358 => 218359)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js 2017-06-15 21:38:49 UTC (rev 218358)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js 2017-06-15 21:50:37 UTC (rev 218359)
@@ -519,7 +519,7 @@
return;
// Avoid highlighting the execution line while debugging.
- if (WebInspector.debuggerManager.paused && (!this._executionLineNumber || line === this._executionLineNumber))
+ if (WebInspector.debuggerManager.paused && line === this._executionLineNumber)
return;
this._codeMirror.addLineClass(lineHandle, "wrap", WebInspector.TextEditor.HighlightedStyleClassName);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
