Title: [218881] trunk/Source/WebCore
- Revision
- 218881
- Author
- commit-qu...@webkit.org
- Date
- 2017-06-28 10:16:54 -0700 (Wed, 28 Jun 2017)
Log Message
Remove unnecessary `const double` method arguments
https://bugs.webkit.org/show_bug.cgi?id=173925
Patch by Antoine Quint <grao...@apple.com> on 2017-06-28
Reviewed by Dean Jackson.
Addressing post-landing feedback from webkit.org/b/173858.
* Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::formattedStringForDuration):
* Modules/mediacontrols/MediaControlsHost.h:
* rendering/RenderTheme.h:
(WebCore::RenderTheme::mediaControlsFormattedStringForDuration):
* rendering/RenderThemeCocoa.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (218880 => 218881)
--- trunk/Source/WebCore/ChangeLog 2017-06-28 16:57:06 UTC (rev 218880)
+++ trunk/Source/WebCore/ChangeLog 2017-06-28 17:16:54 UTC (rev 218881)
@@ -1,3 +1,19 @@
+2017-06-28 Antoine Quint <grao...@apple.com>
+
+ Remove unnecessary `const double` method arguments
+ https://bugs.webkit.org/show_bug.cgi?id=173925
+
+ Reviewed by Dean Jackson.
+
+ Addressing post-landing feedback from webkit.org/b/173858.
+
+ * Modules/mediacontrols/MediaControlsHost.cpp:
+ (WebCore::MediaControlsHost::formattedStringForDuration):
+ * Modules/mediacontrols/MediaControlsHost.h:
+ * rendering/RenderTheme.h:
+ (WebCore::RenderTheme::mediaControlsFormattedStringForDuration):
+ * rendering/RenderThemeCocoa.h:
+
2017-06-28 Zalan Bujtas <za...@apple.com>
Unreviewed, rolling out r218373.
Modified: trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp (218880 => 218881)
--- trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp 2017-06-28 16:57:06 UTC (rev 218880)
+++ trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp 2017-06-28 17:16:54 UTC (rev 218881)
@@ -289,7 +289,7 @@
return RenderTheme::singleton().mediaControlsBase64StringForIconNameAndType(iconName, iconType);
}
-String MediaControlsHost::formattedStringForDuration(const double durationInSeconds) const
+String MediaControlsHost::formattedStringForDuration(double durationInSeconds) const
{
return RenderTheme::singleton().mediaControlsFormattedStringForDuration(durationInSeconds);
}
Modified: trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.h (218880 => 218881)
--- trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.h 2017-06-28 16:57:06 UTC (rev 218880)
+++ trunk/Source/WebCore/Modules/mediacontrols/MediaControlsHost.h 2017-06-28 17:16:54 UTC (rev 218881)
@@ -88,7 +88,7 @@
String shadowRootCSSText() const;
String base64StringForIconNameAndType(const String& iconName, const String& iconType) const;
- String formattedStringForDuration(const double) const;
+ String formattedStringForDuration(double) const;
private:
MediaControlsHost(HTMLMediaElement*);
Modified: trunk/Source/WebCore/rendering/RenderTheme.h (218880 => 218881)
--- trunk/Source/WebCore/rendering/RenderTheme.h 2017-06-28 16:57:06 UTC (rev 218880)
+++ trunk/Source/WebCore/rendering/RenderTheme.h 2017-06-28 17:16:54 UTC (rev 218881)
@@ -94,7 +94,7 @@
virtual String extraMediaControlsStyleSheet() { return String(); }
virtual String mediaControlsScript() { return String(); }
virtual String mediaControlsBase64StringForIconNameAndType(const String&, const String&) { return String(); }
- virtual String mediaControlsFormattedStringForDuration(const double) { return String(); }
+ virtual String mediaControlsFormattedStringForDuration(double) { return String(); }
#endif
#if ENABLE(FULLSCREEN_API)
virtual String extraFullScreenStyleSheet() { return String(); }
Modified: trunk/Source/WebCore/rendering/RenderThemeCocoa.h (218880 => 218881)
--- trunk/Source/WebCore/rendering/RenderThemeCocoa.h 2017-06-28 16:57:06 UTC (rev 218880)
+++ trunk/Source/WebCore/rendering/RenderThemeCocoa.h 2017-06-28 17:16:54 UTC (rev 218881)
@@ -37,7 +37,7 @@
#endif
protected:
#if ENABLE(VIDEO)
- String mediaControlsFormattedStringForDuration(const double) override;
+ String mediaControlsFormattedStringForDuration(double) override;
#endif
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
