Title: [218912] trunk/Source/WebCore
Revision
218912
Author
cdu...@apple.com
Date
2017-06-28 20:28:47 -0700 (Wed, 28 Jun 2017)

Log Message

Avoid copying statistics in ResourceLoadStatisticsStore::readDataFromDecoder()
https://bugs.webkit.org/show_bug.cgi?id=173951

Reviewed by Ryosuke Niwa.

* loader/ResourceLoadStatisticsStore.cpp:
(WebCore::ResourceLoadStatisticsStore::readDataFromDecoder):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (218911 => 218912)


--- trunk/Source/WebCore/ChangeLog	2017-06-29 02:56:22 UTC (rev 218911)
+++ trunk/Source/WebCore/ChangeLog	2017-06-29 03:28:47 UTC (rev 218912)
@@ -1,3 +1,13 @@
+2017-06-28  Chris Dumez  <cdu...@apple.com>
+
+        Avoid copying statistics in ResourceLoadStatisticsStore::readDataFromDecoder()
+        https://bugs.webkit.org/show_bug.cgi?id=173951
+
+        Reviewed by Ryosuke Niwa.
+
+        * loader/ResourceLoadStatisticsStore.cpp:
+        (WebCore::ResourceLoadStatisticsStore::readDataFromDecoder):
+
 2017-06-28  Ryosuke Niwa  <rn...@webkit.org>
 
         Safari's Speedometer score massively regresses when accessibility is enabled

Modified: trunk/Source/WebCore/loader/ResourceLoadStatisticsStore.cpp (218911 => 218912)


--- trunk/Source/WebCore/loader/ResourceLoadStatisticsStore.cpp	2017-06-29 02:56:22 UTC (rev 218911)
+++ trunk/Source/WebCore/loader/ResourceLoadStatisticsStore.cpp	2017-06-29 03:28:47 UTC (rev 218912)
@@ -130,15 +130,15 @@
     prevalentResourceDomainsWithoutUserInteraction.reserveInitialCapacity(loadedStatistics.size());
     
     {
-    auto locker = holdLock(m_statisticsLock);
-    for (auto& statistics : loadedStatistics) {
-        if (statistics.isPrevalentResource && !statistics.hadUserInteraction) {
-            prevalentResourceDomainsWithoutUserInteraction.uncheckedAppend(statistics.highLevelDomain);
-            statistics.isMarkedForCookiePartitioning = true;
+        auto locker = holdLock(m_statisticsLock);
+        for (auto& statistics : loadedStatistics) {
+            if (statistics.isPrevalentResource && !statistics.hadUserInteraction) {
+                prevalentResourceDomainsWithoutUserInteraction.uncheckedAppend(statistics.highLevelDomain);
+                statistics.isMarkedForCookiePartitioning = true;
+            }
+            m_resourceStatisticsMap.set(statistics.highLevelDomain, WTFMove(statistics));
         }
-        m_resourceStatisticsMap.set(statistics.highLevelDomain, statistics);
     }
-    }
     
     fireShouldPartitionCookiesHandler({ }, prevalentResourceDomainsWithoutUserInteraction, true);
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to