Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (219114 => 219115)
--- trunk/Source/_javascript_Core/ChangeLog 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-07-04 08:03:06 UTC (rev 219115)
@@ -1,3 +1,18 @@
+2017-07-04 Joseph Pecoraro <pecor...@apple.com>
+
+ Cleanup some StringBuilder use
+ https://bugs.webkit.org/show_bug.cgi?id=174118
+
+ Reviewed by Andreas Kling.
+
+ * runtime/FunctionConstructor.cpp:
+ (JSC::constructFunctionSkippingEvalEnabledCheck):
+ * tools/FunctionOverrides.cpp:
+ (JSC::parseClause):
+ * wasm/WasmOMGPlan.cpp:
+ * wasm/WasmPlan.cpp:
+ * wasm/WasmValidate.cpp:
+
2017-07-03 Saam Barati <sbar...@apple.com>
LayoutTest workers/bomb.html is a Crash
Modified: trunk/Source/_javascript_Core/runtime/FunctionConstructor.cpp (219114 => 219115)
--- trunk/Source/_javascript_Core/runtime/FunctionConstructor.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/_javascript_Core/runtime/FunctionConstructor.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -137,7 +137,7 @@
program = makeString("{", prefix, functionName.string(), "() {\n", body, "\n}}");
} else {
StringBuilder builder;
- builder.append("{");
+ builder.append('{');
builder.append(prefix);
builder.append(functionName.string());
builder.append('(');
Modified: trunk/Source/_javascript_Core/tools/FunctionOverrides.cpp (219114 => 219115)
--- trunk/Source/_javascript_Core/tools/FunctionOverrides.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/_javascript_Core/tools/FunctionOverrides.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -203,7 +203,7 @@
FAIL_WITH_ERROR(SYNTAX_ERROR, ("Delimiter '", delimiter, "' cannot have '{', '}', or whitespace:\n", line, "\n"));
String terminatorString;
- terminatorString.append("}");
+ terminatorString.append('}');
terminatorString.append(delimiter);
CString terminatorCString = terminatorString.ascii();
Modified: trunk/Source/_javascript_Core/wasm/WasmOMGPlan.cpp (219114 => 219115)
--- trunk/Source/_javascript_Core/wasm/WasmOMGPlan.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/_javascript_Core/wasm/WasmOMGPlan.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -44,7 +44,6 @@
#include <wtf/MonotonicTime.h>
#include <wtf/StdLibExtras.h>
#include <wtf/ThreadMessage.h>
-#include <wtf/text/StringBuilder.h>
namespace JSC { namespace Wasm {
Modified: trunk/Source/_javascript_Core/wasm/WasmPlan.cpp (219114 => 219115)
--- trunk/Source/_javascript_Core/wasm/WasmPlan.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/_javascript_Core/wasm/WasmPlan.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -44,7 +44,6 @@
#include <wtf/MonotonicTime.h>
#include <wtf/StdLibExtras.h>
#include <wtf/SystemTracing.h>
-#include <wtf/text/StringBuilder.h>
namespace JSC { namespace Wasm {
Modified: trunk/Source/_javascript_Core/wasm/WasmValidate.cpp (219114 => 219115)
--- trunk/Source/_javascript_Core/wasm/WasmValidate.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/_javascript_Core/wasm/WasmValidate.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -30,7 +30,6 @@
#include "WasmFunctionParser.h"
#include <wtf/CommaPrinter.h>
-#include <wtf/text/StringBuilder.h>
namespace JSC { namespace Wasm {
Modified: trunk/Source/WebCore/ChangeLog (219114 => 219115)
--- trunk/Source/WebCore/ChangeLog 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebCore/ChangeLog 2017-07-04 08:03:06 UTC (rev 219115)
@@ -1,3 +1,32 @@
+2017-07-04 Joseph Pecoraro <pecor...@apple.com>
+
+ Cleanup some StringBuilder use
+ https://bugs.webkit.org/show_bug.cgi?id=174118
+
+ Reviewed by Andreas Kling.
+
+ * Modules/mediastream/PeerConnectionBackend.cpp:
+ (WebCore::filterICECandidate):
+ * Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
+ * contentextensions/ContentExtension.cpp:
+ (WebCore::ContentExtensions::ContentExtension::compileGlobalDisplayNoneStyleSheet):
+ * css/CSSFontStyleRangeValue.cpp:
+ (WebCore::CSSFontStyleRangeValue::customCSSText):
+ * css/CSSFontStyleValue.cpp:
+ (WebCore::CSSFontStyleValue::customCSSText):
+ * css/CSSGridAutoRepeatValue.cpp:
+ (WebCore::CSSGridAutoRepeatValue::customCSSText):
+ * css/parser/CSSParser.cpp:
+ (WebCore::CSSParser::parseFontFaceDescriptor):
+ * dom/Attr.cpp:
+ * html/canvas/WebGPURenderingContext.cpp:
+ * html/parser/HTMLParserIdioms.cpp:
+ * platform/network/ParsedContentType.cpp:
+ * platform/network/cocoa/CookieCocoa.mm:
+ * platform/text/mac/LocaleMac.mm:
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::getAllResponseHeaders):
+
2017-07-03 Andreas Kling <akl...@apple.com>
Null RenderLayer* deref in FrameView::adjustTiledBackingCoverage()
Modified: trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp (219114 => 219115)
--- trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -323,7 +323,7 @@
if (isFirst)
isFirst = false;
else
- filteredSDP.append(" ");
+ filteredSDP.append(' ');
filteredSDP.append(item);
});
return filteredSDP.toString();
Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp (219114 => 219115)
--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -41,7 +41,6 @@
#include "RTCSessionDescription.h"
#include "RealtimeIncomingAudioSource.h"
#include "RealtimeIncomingVideoSource.h"
-#include <wtf/text/StringBuilder.h>
namespace WebCore {
Modified: trunk/Source/WebCore/contentextensions/ContentExtension.cpp (219114 => 219115)
--- trunk/Source/WebCore/contentextensions/ContentExtension.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebCore/contentextensions/ContentExtension.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -103,9 +103,9 @@
}
if (css.isEmpty())
return;
- css.append("{");
+ css.append('{');
css.append(ContentExtensionsBackend::displayNoneCSSRule());
- css.append("}");
+ css.append('}');
m_globalDisplayNoneStyleSheet = StyleSheetContents::create();
m_globalDisplayNoneStyleSheet->setIsUserStyleSheet(true);
Modified: trunk/Source/WebCore/css/CSSFontStyleRangeValue.cpp (219114 => 219115)
--- trunk/Source/WebCore/css/CSSFontStyleRangeValue.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebCore/css/CSSFontStyleRangeValue.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -37,7 +37,7 @@
StringBuilder builder;
builder.append(fontStyleValue->cssText());
- builder.append(" ");
+ builder.append(' ');
builder.append(obliqueValues->cssText());
return builder.toString();
}
Modified: trunk/Source/WebCore/css/CSSFontStyleValue.cpp (219114 => 219115)
--- trunk/Source/WebCore/css/CSSFontStyleValue.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebCore/css/CSSFontStyleValue.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -37,7 +37,7 @@
StringBuilder builder;
builder.append(fontStyleValue->cssText());
- builder.append(" ");
+ builder.append(' ');
builder.append(obliqueValue->cssText());
return builder.toString();
}
Modified: trunk/Source/WebCore/css/CSSGridAutoRepeatValue.cpp (219114 => 219115)
--- trunk/Source/WebCore/css/CSSGridAutoRepeatValue.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebCore/css/CSSGridAutoRepeatValue.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -42,7 +42,7 @@
result.append(getValueName(autoRepeatID()));
result.append(", ");
result.append(CSSValueList::customCSSText());
- result.append(")");
+ result.append(')');
return result.toString();
}
Modified: trunk/Source/WebCore/css/parser/CSSParser.cpp (219114 => 219115)
--- trunk/Source/WebCore/css/parser/CSSParser.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebCore/css/parser/CSSParser.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -287,11 +287,11 @@
RefPtr<CSSValue> CSSParser::parseFontFaceDescriptor(CSSPropertyID propertyID, const String& propertyValue, const CSSParserContext& context)
{
StringBuilder builder;
- builder.append("@font-face { ");
+ builder.appendLiteral("@font-face { ");
builder.append(getPropertyNameString(propertyID));
- builder.append(" : ");
+ builder.appendLiteral(" : ");
builder.append(propertyValue);
- builder.append("; }");
+ builder.appendLiteral("; }");
RefPtr<StyleRuleBase> rule = parseRule(context, nullptr, builder.toString());
if (!rule || !rule->isFontFaceRule())
return nullptr;
Modified: trunk/Source/WebCore/dom/Attr.cpp (219114 => 219115)
--- trunk/Source/WebCore/dom/Attr.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebCore/dom/Attr.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -33,7 +33,6 @@
#include "TextNodeTraversal.h"
#include "XMLNSNames.h"
#include <wtf/text/AtomicString.h>
-#include <wtf/text/StringBuilder.h>
namespace WebCore {
Modified: trunk/Source/WebCore/html/canvas/WebGPURenderingContext.cpp (219114 => 219115)
--- trunk/Source/WebCore/html/canvas/WebGPURenderingContext.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebCore/html/canvas/WebGPURenderingContext.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -52,7 +52,6 @@
#include <runtime/Uint32Array.h>
#include <wtf/StdLibExtras.h>
#include <wtf/text/CString.h>
-#include <wtf/text/StringBuilder.h>
namespace {
Modified: trunk/Source/WebCore/html/parser/HTMLParserIdioms.cpp (219114 => 219115)
--- trunk/Source/WebCore/html/parser/HTMLParserIdioms.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebCore/html/parser/HTMLParserIdioms.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -32,7 +32,6 @@
#include <wtf/MathExtras.h>
#include <wtf/NeverDestroyed.h>
#include <wtf/dtoa.h>
-#include <wtf/text/StringBuilder.h>
namespace WebCore {
Modified: trunk/Source/WebCore/platform/network/ParsedContentType.cpp (219114 => 219115)
--- trunk/Source/WebCore/platform/network/ParsedContentType.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebCore/platform/network/ParsedContentType.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -33,7 +33,6 @@
#include "ParsedContentType.h"
#include <wtf/text/CString.h>
-#include <wtf/text/StringBuilder.h>
namespace WebCore {
Modified: trunk/Source/WebCore/platform/network/cocoa/CookieCocoa.mm (219114 => 219115)
--- trunk/Source/WebCore/platform/network/cocoa/CookieCocoa.mm 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebCore/platform/network/cocoa/CookieCocoa.mm 2017-07-04 08:03:06 UTC (rev 219115)
@@ -26,8 +26,6 @@
#import "config.h"
#import "Cookie.h"
-#import <wtf/text/StringBuilder.h>
-
namespace WebCore {
static Vector<uint16_t> portVectorFromList(NSArray<NSNumber *> *portList)
Modified: trunk/Source/WebCore/platform/text/mac/LocaleMac.mm (219114 => 219115)
--- trunk/Source/WebCore/platform/text/mac/LocaleMac.mm 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebCore/platform/text/mac/LocaleMac.mm 2017-07-04 08:03:06 UTC (rev 219115)
@@ -37,7 +37,6 @@
#include "LocalizedStrings.h"
#include <wtf/DateMath.h>
#include <wtf/RetainPtr.h>
-#include <wtf/text/StringBuilder.h>
#if PLATFORM(IOS)
#import "LocalizedDateCache.h"
Modified: trunk/Source/WebCore/xml/XMLHttpRequest.cpp (219114 => 219115)
--- trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -938,9 +938,9 @@
for (auto& header : m_response.httpHeaderFields()) {
StringBuilder stringBuilder;
stringBuilder.append(header.key.convertToASCIILowercase());
- stringBuilder.append(": ");
+ stringBuilder.appendLiteral(": ");
stringBuilder.append(header.value);
- stringBuilder.append("\r\n");
+ stringBuilder.appendLiteral("\r\n");
headers.uncheckedAppend(stringBuilder.toString());
}
std::sort(headers.begin(), headers.end(), WTF::codePointCompareLessThan);
Modified: trunk/Source/WebKit2/ChangeLog (219114 => 219115)
--- trunk/Source/WebKit2/ChangeLog 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebKit2/ChangeLog 2017-07-04 08:03:06 UTC (rev 219115)
@@ -1,3 +1,14 @@
+2017-07-04 Joseph Pecoraro <pecor...@apple.com>
+
+ Cleanup some StringBuilder use
+ https://bugs.webkit.org/show_bug.cgi?id=174118
+
+ Reviewed by Andreas Kling.
+
+ * NetworkProcess/capture/NetworkCaptureManager.cpp:
+ (WebKit::NetworkCapture::Manager::hashToPath):
+ * UIProcess/WebPageProxy.cpp:
+
2017-07-03 Wenson Hsieh <wenson_hs...@apple.com>
[iOS DnD] [WK2] Callout bar should reappear after dragging ends for a text selection
Modified: trunk/Source/WebKit2/NetworkProcess/capture/NetworkCaptureManager.cpp (219114 => 219115)
--- trunk/Source/WebKit2/NetworkProcess/capture/NetworkCaptureManager.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebKit2/NetworkProcess/capture/NetworkCaptureManager.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -409,7 +409,7 @@
StringBuilder fileName;
fileName.append(hashTail);
- fileName.append(".data");
+ fileName.appendLiteral(".data");
auto path = WebCore::pathByAppendingComponent(m_recordReplayCacheLocation, kDirNameResources);
path = WebCore::pathByAppendingComponent(path, hashHead);
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (219114 => 219115)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2017-07-04 05:18:15 UTC (rev 219114)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2017-07-04 08:03:06 UTC (rev 219115)
@@ -139,7 +139,6 @@
#include <stdio.h>
#include <wtf/NeverDestroyed.h>
#include <wtf/SystemTracing.h>
-#include <wtf/text/StringBuilder.h>
#include <wtf/text/StringView.h>
#if ENABLE(ASYNC_SCROLLING)
