Title: [219307] trunk/Source/WebCore
Revision
219307
Author
commit-qu...@webkit.org
Date
2017-07-10 13:58:32 -0700 (Mon, 10 Jul 2017)

Log Message

Captions and subtitles not showing up in picture-in-picture for MSE content
https://bugs.webkit.org/show_bug.cgi?id=174317
rdar://problem/33188591

Patch by Jeremy Jones <jere...@apple.com> on 2017-07-10
Reviewed by Eric Carlson.

Reverts a regression created by r218403.

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentation):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (219306 => 219307)


--- trunk/Source/WebCore/ChangeLog	2017-07-10 20:09:04 UTC (rev 219306)
+++ trunk/Source/WebCore/ChangeLog	2017-07-10 20:58:32 UTC (rev 219307)
@@ -1,3 +1,16 @@
+2017-07-10  Jeremy Jones  <jere...@apple.com>
+
+        Captions and subtitles not showing up in picture-in-picture for MSE content
+        https://bugs.webkit.org/show_bug.cgi?id=174317
+        rdar://problem/33188591
+
+        Reviewed by Eric Carlson.
+
+        Reverts a regression created by r218403.
+
+        * html/shadow/MediaControlElements.cpp:
+        (WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentation):
+
 2017-07-10  Per Arne Vollan  <pvol...@apple.com>
 
         [Win] Link error when building WTF from WTF.proj project file.

Modified: trunk/Source/WebCore/html/shadow/MediaControlElements.cpp (219306 => 219307)


--- trunk/Source/WebCore/html/shadow/MediaControlElements.cpp	2017-07-10 20:09:04 UTC (rev 219306)
+++ trunk/Source/WebCore/html/shadow/MediaControlElements.cpp	2017-07-10 20:58:32 UTC (rev 219307)
@@ -1296,7 +1296,6 @@
         mediaElement->setTextTrackRepresentation(m_textTrackRepresentation.get());
     }
 
-    hide();
     m_textTrackRepresentation->update();
     updateStyleForTextTrackRepresentation();
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to