Title: [219608] trunk/Source/WebDriver
Revision
219608
Author
clo...@igalia.com
Date
2017-07-18 04:21:53 -0700 (Tue, 18 Jul 2017)

Log Message

[GTK] Fix build with Clang after r219605.
https://bugs.webkit.org/show_bug.cgi?id=166682

Unreviewed build fix.

Clang-3.8 complains with the following error:
non-constant-_expression_ cannot be narrowed from type 'gboolean' (aka 'int') to 'bool' in initializer list [-Wc++11-narrowing]

* glib/SessionHostGlib.cpp: insert an explicit cast to silence this issue.

Modified Paths

Diff

Modified: trunk/Source/WebDriver/ChangeLog (219607 => 219608)


--- trunk/Source/WebDriver/ChangeLog	2017-07-18 07:33:35 UTC (rev 219607)
+++ trunk/Source/WebDriver/ChangeLog	2017-07-18 11:21:53 UTC (rev 219608)
@@ -1,3 +1,15 @@
+2017-07-18  Carlos Alberto Lopez Perez  <clo...@igalia.com>
+
+        [GTK] Fix build with Clang after r219605.
+        https://bugs.webkit.org/show_bug.cgi?id=166682
+
+        Unreviewed build fix.
+
+        Clang-3.8 complains with the following error:
+        non-constant-_expression_ cannot be narrowed from type 'gboolean' (aka 'int') to 'bool' in initializer list [-Wc++11-narrowing]
+
+        * glib/SessionHostGlib.cpp: insert an explicit cast to silence this issue.
+
 2017-07-13  Carlos Garcia Campos  <cgar...@igalia.com>
 
         Add initial implementation of WebDriver process to run the HTTP server

Modified: trunk/Source/WebDriver/glib/SessionHostGlib.cpp (219607 => 219608)


--- trunk/Source/WebDriver/glib/SessionHostGlib.cpp	2017-07-18 07:33:35 UTC (rev 219607)
+++ trunk/Source/WebDriver/glib/SessionHostGlib.cpp	2017-07-18 11:21:53 UTC (rev 219608)
@@ -77,7 +77,7 @@
             gboolean isPaired;
             while (g_variant_iter_loop(iter.get(), "(t&s&s&sb)", &targetID, &type, &name, &dummy, &isPaired)) {
                 if (!g_strcmp0(type, "Automation"))
-                    targetList.uncheckedAppend({ targetID, name, isPaired });
+                    targetList.uncheckedAppend({ targetID, name, static_cast<bool>(isPaired) });
             }
             sessionHost->setTargetList(connectionID, WTFMove(targetList));
             g_dbus_method_invocation_return_value(invocation, nullptr);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to