Title: [220139] trunk/Tools
Revision
220139
Author
aakash_j...@apple.com
Date
2017-08-02 10:54:41 -0700 (Wed, 02 Aug 2017)

Log Message

Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
https://bugs.webkit.org/show_bug.cgi?id=175072

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js (220138 => 220139)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js	2017-08-02 17:51:23 UTC (rev 220138)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js	2017-08-02 17:54:41 UTC (rev 220139)
@@ -44,8 +44,10 @@
 
     this.VERSION_LESS_THAN_09 = options && options.USE_BUILDBOT_VERSION_LESS_THAN_09;
 
-    if (!this.VERSION_LESS_THAN_09)
+    if (!this.VERSION_LESS_THAN_09) {
+        this._builderNameToIDMap = {};
         this._computeBuilderNameToIDMap();
+    }
 
     for (var id in queuesInfo) {
         if (queuesInfo[id].combinedQueues) {
@@ -158,7 +160,6 @@
             if (!data || !(data.builders instanceof Array))
                 return;
 
-            this._builderNameToIDMap = {};
             for (var builder of data.builders)
                 this._builderNameToIDMap[builder.name] = builder.builderid;
         }.bind(this));

Modified: trunk/Tools/ChangeLog (220138 => 220139)


--- trunk/Tools/ChangeLog	2017-08-02 17:51:23 UTC (rev 220138)
+++ trunk/Tools/ChangeLog	2017-08-02 17:54:41 UTC (rev 220139)
@@ -1,3 +1,13 @@
+2017-08-02  Aakash Jain  <aakash_j...@apple.com>
+
+        Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
+        https://bugs.webkit.org/show_bug.cgi?id=175072
+
+        Reviewed by Alexey Proskuryakov.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
+        (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
+
 2017-08-02  Michael Catanzaro  <mcatanz...@igalia.com>
 
         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to