Title: [220781] trunk/Source/WebCore
- Revision
- 220781
- Author
- simon.fra...@apple.com
- Date
- 2017-08-15 19:05:28 -0700 (Tue, 15 Aug 2017)
Log Message
Remove ScrollView::clipsRepaints() which was only used by Chromium
https://bugs.webkit.org/show_bug.cgi?id=175594
Reviewed by Tim Horton.
clipsRepaints() was added in r74568 but was only used by Chromium. It's always
true for other platforms, so remove conditionals that test for it and assume true.
* page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):
* platform/ScrollView.cpp:
(WebCore::ScrollView::repaintContentRectangle):
(WebCore::ScrollView::setClipsRepaints): Deleted.
* platform/ScrollView.h:
(WebCore::ScrollView::clipsRepaints const): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (220780 => 220781)
--- trunk/Source/WebCore/ChangeLog 2017-08-16 01:37:30 UTC (rev 220780)
+++ trunk/Source/WebCore/ChangeLog 2017-08-16 02:05:28 UTC (rev 220781)
@@ -1,5 +1,23 @@
2017-08-15 Simon Fraser <simon.fra...@apple.com>
+ Remove ScrollView::clipsRepaints() which was only used by Chromium
+ https://bugs.webkit.org/show_bug.cgi?id=175594
+
+ Reviewed by Tim Horton.
+
+ clipsRepaints() was added in r74568 but was only used by Chromium. It's always
+ true for other platforms, so remove conditionals that test for it and assume true.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::scrollContentsFastPath):
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::repaintContentRectangle):
+ (WebCore::ScrollView::setClipsRepaints): Deleted.
+ * platform/ScrollView.h:
+ (WebCore::ScrollView::clipsRepaints const): Deleted.
+
+2017-08-15 Simon Fraser <simon.fra...@apple.com>
+
Allow WebCore logging channels to be set from the UI process
https://bugs.webkit.org/show_bug.cgi?id=175608
Modified: trunk/Source/WebCore/page/FrameView.cpp (220780 => 220781)
--- trunk/Source/WebCore/page/FrameView.cpp 2017-08-16 01:37:30 UTC (rev 220780)
+++ trunk/Source/WebCore/page/FrameView.cpp 2017-08-16 02:05:28 UTC (rev 220781)
@@ -2309,7 +2309,7 @@
// FIXME: use pixel snapping instead of enclosing when ScrollView has finished transitioning from IntRect to Float/LayoutRect.
IntRect updateRect = enclosingIntRect(layer->repaintRectIncludingNonCompositingDescendants());
updateRect = contentsToRootView(updateRect);
- if (!isCompositedContentLayer && clipsRepaints())
+ if (!isCompositedContentLayer)
updateRect.intersect(rectToScroll);
if (!updateRect.isEmpty())
regionToUpdate.unite(updateRect);
@@ -2329,8 +2329,7 @@
renderView()->layer()->setBackingNeedsRepaintInRect(updateRect);
continue;
}
- if (clipsRepaints())
- updateRect.intersect(rectToScroll);
+ updateRect.intersect(rectToScroll);
frame().page()->chrome().invalidateContentsAndRootView(updateRect);
}
Modified: trunk/Source/WebCore/platform/ScrollView.cpp (220780 => 220781)
--- trunk/Source/WebCore/platform/ScrollView.cpp 2017-08-16 01:37:30 UTC (rev 220780)
+++ trunk/Source/WebCore/platform/ScrollView.cpp 2017-08-16 02:05:28 UTC (rev 220781)
@@ -192,11 +192,6 @@
m_paintsEntireContents = paintsEntireContents;
}
-void ScrollView::setClipsRepaints(bool clipsRepaints)
-{
- m_clipsRepaints = clipsRepaints;
-}
-
void ScrollView::setDelegatesScrolling(bool delegatesScrolling)
{
if (m_delegatesScrolling == delegatesScrolling)
@@ -1071,7 +1066,7 @@
void ScrollView::repaintContentRectangle(const IntRect& rect)
{
IntRect paintRect = rect;
- if (clipsRepaints() && !paintsEntireContents())
+ if (!paintsEntireContents())
paintRect.intersect(visibleContentRect(LegacyIOSDocumentVisibleRect));
if (paintRect.isEmpty())
return;
Modified: trunk/Source/WebCore/platform/ScrollView.h (220780 => 220781)
--- trunk/Source/WebCore/platform/ScrollView.h 2017-08-16 01:37:30 UTC (rev 220780)
+++ trunk/Source/WebCore/platform/ScrollView.h 2017-08-16 02:05:28 UTC (rev 220781)
@@ -129,11 +129,6 @@
bool paintsEntireContents() const { return m_paintsEntireContents; }
WEBCORE_EXPORT void setPaintsEntireContents(bool);
- // By default, paint events are clipped to the visible area. If set to
- // false, paint events are no longer clipped. paintsEntireContents() implies !clipsRepaints().
- bool clipsRepaints() const { return m_clipsRepaints; }
- void setClipsRepaints(bool);
-
// By default programmatic scrolling is handled by WebCore and not by the UI application.
// In the case of using a tiled backing store, this mode can be set, so that the scroll requests
// are delegated to the UI application.
@@ -481,7 +476,6 @@
bool m_useFixedLayout { false };
bool m_paintsEntireContents { false };
- bool m_clipsRepaints { true };
bool m_delegatesScrolling { false };
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
