Title: [221000] trunk/Source/_javascript_Core
- Revision
- 221000
- Author
- keith_mil...@apple.com
- Date
- 2017-08-21 20:19:46 -0700 (Mon, 21 Aug 2017)
Log Message
Make generate_offset_extractor.rb architectures argument more robust
https://bugs.webkit.org/show_bug.cgi?id=175809
Reviewed by Joseph Pecoraro.
It turns out that some of our builders pass their architectures as
space separated lists. I decided to just make the splitting of
our list robust to any reasonable combination of spaces and
commas.
* offlineasm/generate_offset_extractor.rb:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (220999 => 221000)
--- trunk/Source/_javascript_Core/ChangeLog 2017-08-22 02:25:12 UTC (rev 220999)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-08-22 03:19:46 UTC (rev 221000)
@@ -1,5 +1,19 @@
2017-08-21 Keith Miller <keith_mil...@apple.com>
+ Make generate_offset_extractor.rb architectures argument more robust
+ https://bugs.webkit.org/show_bug.cgi?id=175809
+
+ Reviewed by Joseph Pecoraro.
+
+ It turns out that some of our builders pass their architectures as
+ space separated lists. I decided to just make the splitting of
+ our list robust to any reasonable combination of spaces and
+ commas.
+
+ * offlineasm/generate_offset_extractor.rb:
+
+2017-08-21 Keith Miller <keith_mil...@apple.com>
+
Only generate offline asm for the ARCHS (xcodebuild) or the current system (CMake)
https://bugs.webkit.org/show_bug.cgi?id=175690
Modified: trunk/Source/_javascript_Core/offlineasm/generate_offset_extractor.rb (220999 => 221000)
--- trunk/Source/_javascript_Core/offlineasm/generate_offset_extractor.rb 2017-08-22 02:25:12 UTC (rev 220999)
+++ trunk/Source/_javascript_Core/offlineasm/generate_offset_extractor.rb 2017-08-22 03:19:46 UTC (rev 221000)
@@ -39,7 +39,7 @@
inputFlnm = ARGV.shift
outputFlnm = ARGV.shift
-validBackends = canonicalizeBackendNames(ARGV.shift.split(","))
+validBackends = canonicalizeBackendNames(ARGV.shift.split(/[,\s]+/))
$stderr.puts "Only dealing with backends: #{validBackends}"
includeOnlyBackends(validBackends)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
