Title: [221043] trunk/Source/WebKit
Revision
221043
Author
ryanhad...@apple.com
Date
2017-08-22 13:53:15 -0700 (Tue, 22 Aug 2017)

Log Message

Unreviewed, rolling out r221027.

This change caused LayoutTests to exit early with assertion
failures.

Reverted changeset:

"Add sanity check for source origin in
WebLoaderStrategy::startPingLoad()"
https://bugs.webkit.org/show_bug.cgi?id=175827
http://trac.webkit.org/changeset/221027

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (221042 => 221043)


--- trunk/Source/WebKit/ChangeLog	2017-08-22 20:53:08 UTC (rev 221042)
+++ trunk/Source/WebKit/ChangeLog	2017-08-22 20:53:15 UTC (rev 221043)
@@ -1,3 +1,17 @@
+2017-08-22  Ryan Haddad  <ryanhad...@apple.com>
+
+        Unreviewed, rolling out r221027.
+
+        This change caused LayoutTests to exit early with assertion
+        failures.
+
+        Reverted changeset:
+
+        "Add sanity check for source origin in
+        WebLoaderStrategy::startPingLoad()"
+        https://bugs.webkit.org/show_bug.cgi?id=175827
+        http://trac.webkit.org/changeset/221027
+
 2017-08-22  Chris Dumez  <cdu...@apple.com>
 
         [WK2] Enable Beacon API by default

Modified: trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp (221042 => 221043)


--- trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp	2017-08-22 20:53:08 UTC (rev 221042)
+++ trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp	2017-08-22 20:53:15 UTC (rev 221043)
@@ -425,7 +425,6 @@
     loadParameters.identifier = generatePingLoadIdentifier();
     loadParameters.request = request;
     loadParameters.sourceOrigin = &document->securityOrigin();
-    ASSERT(loadParameters.request.httpHeaderField(HTTPHeaderName::Origin).isNull() || loadParameters.request.httpHeaderField(HTTPHeaderName::Origin) == loadParameters.sourceOrigin->toString());
     loadParameters.sessionID = webPage ? webPage->sessionID() : PAL::SessionID::defaultSessionID();
     loadParameters.allowStoredCredentials = options.credentials == FetchOptions::Credentials::Omit ? DoNotAllowStoredCredentials : AllowStoredCredentials;
     loadParameters.mode = options.mode;
@@ -432,7 +431,7 @@
     loadParameters.shouldFollowRedirects = options.redirect == FetchOptions::Redirect::Follow;
     loadParameters.shouldClearReferrerOnHTTPSToHTTPRedirect = networkingContext->shouldClearReferrerOnHTTPSToHTTPRedirect();
     if (!document->shouldBypassMainWorldContentSecurityPolicy()) {
-        if (auto* contentSecurityPolicy = document->contentSecurityPolicy())
+        if (auto * contentSecurityPolicy = document->contentSecurityPolicy())
             loadParameters.cspResponseHeaders = contentSecurityPolicy->responseHeaders();
     }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to