Title: [221062] trunk
- Revision
- 221062
- Author
- jlew...@apple.com
- Date
- 2017-08-22 18:12:09 -0700 (Tue, 22 Aug 2017)
Log Message
Unreviewed, rolling out r221033.
This revision caused assertion failures on all Open Source
Debug testers. See Radar for more information.
Reverted changeset:
"Ensure media controls host exists before using it"
https://bugs.webkit.org/show_bug.cgi?id=175833
http://trac.webkit.org/changeset/221033
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (221061 => 221062)
--- trunk/LayoutTests/ChangeLog 2017-08-23 01:05:22 UTC (rev 221061)
+++ trunk/LayoutTests/ChangeLog 2017-08-23 01:12:09 UTC (rev 221062)
@@ -1,5 +1,18 @@
2017-08-22 Matt Lewis <jlew...@apple.com>
+ Unreviewed, rolling out r221033.
+
+ This revision caused assertion failures on all Open Source
+ Debug testers. See Radar for more information.
+
+ Reverted changeset:
+
+ "Ensure media controls host exists before using it"
+ https://bugs.webkit.org/show_bug.cgi?id=175833
+ http://trac.webkit.org/changeset/221033
+
+2017-08-22 Matt Lewis <jlew...@apple.com>
+
Marked http/tests/loading/basic-auth-remove-credentials.html as falky on macOS.
https://bugs.webkit.org/show_bug.cgi?id=173500
Deleted: trunk/LayoutTests/media/track/track-display-before-controls-crash-expected.txt (221061 => 221062)
--- trunk/LayoutTests/media/track/track-display-before-controls-crash-expected.txt 2017-08-23 01:05:22 UTC (rev 221061)
+++ trunk/LayoutTests/media/track/track-display-before-controls-crash-expected.txt 2017-08-23 01:12:09 UTC (rev 221062)
@@ -1,9 +0,0 @@
-Tests triggering track display before media controls are created. Test passes if it does not crash.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/media/track/track-display-before-controls-crash.html (221061 => 221062)
--- trunk/LayoutTests/media/track/track-display-before-controls-crash.html 2017-08-23 01:05:22 UTC (rev 221061)
+++ trunk/LayoutTests/media/track/track-display-before-controls-crash.html 2017-08-23 01:12:09 UTC (rev 221062)
@@ -1,20 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<script src=""
-<script>
- description("Tests triggering track display before media controls are created. Test passes if it does not crash.");
-</script>
-</head>
-<body>
- <template>
- <video>
- <source>
- <audio>
- <track src="" default="C">Test Track 1</track>
- </audio>
- </source>
- </video>
- </template>
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (221061 => 221062)
--- trunk/Source/WebCore/ChangeLog 2017-08-23 01:05:22 UTC (rev 221061)
+++ trunk/Source/WebCore/ChangeLog 2017-08-23 01:12:09 UTC (rev 221062)
@@ -1,3 +1,16 @@
+2017-08-22 Matt Lewis <jlew...@apple.com>
+
+ Unreviewed, rolling out r221033.
+
+ This revision caused assertion failures on all Open Source
+ Debug testers. See Radar for more information.
+
+ Reverted changeset:
+
+ "Ensure media controls host exists before using it"
+ https://bugs.webkit.org/show_bug.cgi?id=175833
+ http://trac.webkit.org/changeset/221033
+
2017-08-22 Per Arne Vollan <pvol...@apple.com>
[Win] Fix compile errors.
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (221061 => 221062)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-08-23 01:05:22 UTC (rev 221061)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-08-23 01:12:09 UTC (rev 221062)
@@ -5967,8 +5967,6 @@
#if ENABLE(MEDIA_CONTROLS_SCRIPT)
ensureMediaControlsShadowRoot();
ASSERT(m_mediaControlsHost);
- if (!m_mediaControlsHost)
- m_mediaControlsHost = MediaControlsHost::create(this);
m_mediaControlsHost->updateTextTrackContainer();
#else
if (!hasMediaControls() && !createMediaControls())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
