Title: [221161] trunk/Source/WebKit
Revision
221161
Author
timothy_hor...@apple.com
Date
2017-08-24 14:41:50 -0700 (Thu, 24 Aug 2017)

Log Message

Overflow scroll views are inset to avoid safe areas even if the parent view is not
https://bugs.webkit.org/show_bug.cgi?id=175949
<rdar://problem/34063057>

Reviewed by Beth Dakin.

* UIProcess/ios/RemoteLayerTreeHostIOS.mm:
(WebKit::RemoteLayerTreeHost::createLayer):
Disable automatic content inset adjustment to avoid safe areas on
all of WKWebView's child UIScrollViews.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (221160 => 221161)


--- trunk/Source/WebKit/ChangeLog	2017-08-24 21:14:43 UTC (rev 221160)
+++ trunk/Source/WebKit/ChangeLog	2017-08-24 21:41:50 UTC (rev 221161)
@@ -1,5 +1,18 @@
 2017-08-24  Tim Horton  <timothy_hor...@apple.com>
 
+        Overflow scroll views are inset to avoid safe areas even if the parent view is not
+        https://bugs.webkit.org/show_bug.cgi?id=175949
+        <rdar://problem/34063057>
+
+        Reviewed by Beth Dakin.
+
+        * UIProcess/ios/RemoteLayerTreeHostIOS.mm:
+        (WebKit::RemoteLayerTreeHost::createLayer):
+        Disable automatic content inset adjustment to avoid safe areas on
+        all of WKWebView's child UIScrollViews.
+
+2017-08-24  Tim Horton  <timothy_hor...@apple.com>
+
         Layout size override changes during in-flight animated resize are dropped on the floor forever
         https://bugs.webkit.org/show_bug.cgi?id=175916
         <rdar://problem/33887295>

Modified: trunk/Source/WebKit/UIProcess/ios/RemoteLayerTreeHostIOS.mm (221160 => 221161)


--- trunk/Source/WebKit/UIProcess/ios/RemoteLayerTreeHostIOS.mm	2017-08-24 21:14:43 UTC (rev 221160)
+++ trunk/Source/WebKit/UIProcess/ios/RemoteLayerTreeHostIOS.mm	2017-08-24 21:41:50 UTC (rev 221161)
@@ -221,9 +221,13 @@
         view = adoptNS([[WKShapeView alloc] init]);
         break;
     case PlatformCALayer::LayerTypeScrollingLayer:
-        if (!m_isDebugLayerTreeHost)
-            view = adoptNS([[UIScrollView alloc] init]);
-        else // The debug indicator parents views under layers, which can cause crashes with UIScrollView.
+        if (!m_isDebugLayerTreeHost) {
+            auto scrollView = adoptNS([[UIScrollView alloc] init]);
+#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000
+            [scrollView setContentInsetAdjustmentBehavior:UIScrollViewContentInsetAdjustmentNever];
+#endif
+            view = scrollView;
+        } else // The debug indicator parents views under layers, which can cause crashes with UIScrollView.
             view = adoptNS([[UIView alloc] init]);
         break;
     default:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to