Title: [221165] trunk/Source/WebKit
Revision
221165
Author
beid...@apple.com
Date
2017-08-24 15:37:15 -0700 (Thu, 24 Aug 2017)

Log Message

Remove duplicate WebCore::URL encoder/decoder
https://bugs.webkit.org/show_bug.cgi?id=175952

Reviewed by Chris Dumez.

Don't need the WebCoreArgumentCoder in WebKit since the URL class defines its own coders.

* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<URL>::encode): Deleted.
(IPC::ArgumentCoder<URL>::decode): Deleted.
* Shared/WebCoreArgumentCoders.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (221164 => 221165)


--- trunk/Source/WebKit/ChangeLog	2017-08-24 22:10:57 UTC (rev 221164)
+++ trunk/Source/WebKit/ChangeLog	2017-08-24 22:37:15 UTC (rev 221165)
@@ -1,3 +1,17 @@
+2017-08-24  Brady Eidson  <beid...@apple.com>
+
+        Remove duplicate WebCore::URL encoder/decoder
+        https://bugs.webkit.org/show_bug.cgi?id=175952
+
+        Reviewed by Chris Dumez.
+
+        Don't need the WebCoreArgumentCoder in WebKit since the URL class defines its own coders.
+
+        * Shared/WebCoreArgumentCoders.cpp:
+        (IPC::ArgumentCoder<URL>::encode): Deleted.
+        (IPC::ArgumentCoder<URL>::decode): Deleted.
+        * Shared/WebCoreArgumentCoders.h:
+
 2017-08-24  Alex Christensen  <achristen...@webkit.org>
 
         Add WKUIDelegatePrivate callback corresponding to PageUIClient's didNotHandleWheelEvent

Modified: trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp (221164 => 221165)


--- trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp	2017-08-24 22:10:57 UTC (rev 221164)
+++ trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp	2017-08-24 22:37:15 UTC (rev 221165)
@@ -1816,20 +1816,6 @@
     return true;
 }
 
-void ArgumentCoder<URL>::encode(Encoder& encoder, const URL& result)
-{
-    encoder << result.string();
-}
-    
-bool ArgumentCoder<URL>::decode(Decoder& decoder, URL& result)
-{
-    String urlAsString;
-    if (!decoder.decode(urlAsString))
-        return false;
-    result = URL(ParsedURLString, urlAsString);
-    return true;
-}
-
 void ArgumentCoder<UserStyleSheet>::encode(Encoder& encoder, const UserStyleSheet& userStyleSheet)
 {
     encoder << userStyleSheet.source();

Modified: trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h (221164 => 221165)


--- trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h	2017-08-24 22:10:57 UTC (rev 221164)
+++ trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h	2017-08-24 22:37:15 UTC (rev 221165)
@@ -485,11 +485,6 @@
     static void encode(Encoder&, const WebCore::TextCheckingResult&);
     static bool decode(Decoder&, WebCore::TextCheckingResult&);
 };
-    
-template<> struct ArgumentCoder<WebCore::URL> {
-    static void encode(Encoder&, const WebCore::URL&);
-    static bool decode(Decoder&, WebCore::URL&);
-};
 
 template<> struct ArgumentCoder<WebCore::UserStyleSheet> {
     static void encode(Encoder&, const WebCore::UserStyleSheet&);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to