Title: [221321] trunk/Source/WebCore
- Revision
- 221321
- Author
- aes...@apple.com
- Date
- 2017-08-29 16:32:36 -0700 (Tue, 29 Aug 2017)
Log Message
REGRESSION (r215290): "Where From" metadata is empty when dragging an image out of Safari
https://bugs.webkit.org/show_bug.cgi?id=176068
Reviewed by Wenson Hsieh.
If you drag an image out of Safari, drop it on the Desktop, and open "Get Info", there is a
"Where from:" field under "More Info" that should list the image's URL. After r215290, this
field is blank due to a mixup with the string passed to URLWithUserTypedString().
Fix this by passing metadataURLString to URLWithUserTypedString() instead of urlString.
Not possible to reliably test this since WebKit adds metadata on a global concurrent queue.
* platform/mac/FileSystemMac.mm:
(WebCore::setMetadataURL):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (221320 => 221321)
--- trunk/Source/WebCore/ChangeLog 2017-08-29 23:10:46 UTC (rev 221320)
+++ trunk/Source/WebCore/ChangeLog 2017-08-29 23:32:36 UTC (rev 221321)
@@ -1,3 +1,21 @@
+2017-08-29 Andy Estes <aes...@apple.com>
+
+ REGRESSION (r215290): "Where From" metadata is empty when dragging an image out of Safari
+ https://bugs.webkit.org/show_bug.cgi?id=176068
+
+ Reviewed by Wenson Hsieh.
+
+ If you drag an image out of Safari, drop it on the Desktop, and open "Get Info", there is a
+ "Where from:" field under "More Info" that should list the image's URL. After r215290, this
+ field is blank due to a mixup with the string passed to URLWithUserTypedString().
+
+ Fix this by passing metadataURLString to URLWithUserTypedString() instead of urlString.
+
+ Not possible to reliably test this since WebKit adds metadata on a global concurrent queue.
+
+ * platform/mac/FileSystemMac.mm:
+ (WebCore::setMetadataURL):
+
2017-08-29 Youenn Fablet <you...@apple.com>
CacheStorage does not need to sort its caches
Modified: trunk/Source/WebCore/platform/mac/FileSystemMac.mm (221320 => 221321)
--- trunk/Source/WebCore/platform/mac/FileSystemMac.mm 2017-08-29 23:10:46 UTC (rev 221320)
+++ trunk/Source/WebCore/platform/mac/FileSystemMac.mm 2017-08-29 23:32:36 UTC (rev 221321)
@@ -52,7 +52,7 @@
void setMetadataURL(const String& path, const String& metadataURLString, const String& referrer)
{
String urlString;
- if (NSURL *url = "" nil))
+ if (NSURL *url = "" nil))
urlString = userVisibleString(URLByRemovingUserInfo(url));
else
urlString = metadataURLString;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
