Title: [221649] trunk/Tools
- Revision
- 221649
- Author
- aakash_j...@apple.com
- Date
- 2017-09-05 16:54:17 -0700 (Tue, 05 Sep 2017)
Log Message
EWS should report when a step succeeds
https://bugs.webkit.org/show_bug.cgi?id=176332
<rdar://problem/25224607>
Reviewed by Sam Weinig.
Most of the EWSes report only if a step fails, but do not report when a step succeed. For e.g.: If a build succeeds,
EWS does not report it. Information about a step passing is sometimes very valuable, especially when waiting for a
patch to complete processing. Sometimes, patch authors know that their changes are not covered by any tests. Having EWS
display that build was successful and it is currently running tests is valuable.
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.command_passed): Update the EWS status server when a command pass. This is
similar to what is done in Commit Queue and Style Queue.
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest._default_expected_logs): Updated unit-tests appropriately.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (221648 => 221649)
--- trunk/Tools/ChangeLog 2017-09-05 23:38:11 UTC (rev 221648)
+++ trunk/Tools/ChangeLog 2017-09-05 23:54:17 UTC (rev 221649)
@@ -1,3 +1,22 @@
+2017-09-05 Aakash Jain <aakash_j...@apple.com>
+
+ EWS should report when a step succeeds
+ https://bugs.webkit.org/show_bug.cgi?id=176332
+ <rdar://problem/25224607>
+
+ Reviewed by Sam Weinig.
+
+ Most of the EWSes report only if a step fails, but do not report when a step succeed. For e.g.: If a build succeeds,
+ EWS does not report it. Information about a step passing is sometimes very valuable, especially when waiting for a
+ patch to complete processing. Sometimes, patch authors know that their changes are not covered by any tests. Having EWS
+ display that build was successful and it is currently running tests is valuable.
+
+ * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+ (AbstractEarlyWarningSystem.command_passed): Update the EWS status server when a command pass. This is
+ similar to what is done in Commit Queue and Style Queue.
+ * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
+ (EarlyWarningSystemTest._default_expected_logs): Updated unit-tests appropriately.
+
2017-09-05 Myles C. Maxfield <mmaxfi...@apple.com>
WSL should support the bool type
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py (221648 => 221649)
--- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py 2017-09-05 23:38:11 UTC (rev 221648)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py 2017-09-05 23:54:17 UTC (rev 221649)
@@ -127,7 +127,7 @@
self.run_webkit_patch(command + [self._deprecated_port.flag()] + (['--architecture=%s' % self._port.architecture()] if self._port.architecture() and self._port.did_override_architecture else []))
def command_passed(self, message, patch):
- pass
+ self._update_status(message, patch=patch)
def command_failed(self, message, script_error, patch):
failure_log = self._log_from_script_error_for_upload(script_error)
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py (221648 => 221649)
--- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py 2017-09-05 23:38:11 UTC (rev 221648)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py 2017-09-05 23:54:17 UTC (rev 221649)
@@ -119,13 +119,13 @@
}
if ews.should_build:
- build_line = "Running: webkit-patch --status-host=example.com build --no-clean --no-update --build-style=%(build_style)s --group=%(group)s --port=%(port)s%(architecture)s\n" % string_replacements
+ build_line = "Running: webkit-patch --status-host=example.com build --no-clean --no-update --build-style=%(build_style)s --group=%(group)s --port=%(port)s%(architecture)s\nMOCK: update_status: %(name)s Built patch\n" % string_replacements
else:
build_line = ""
string_replacements['build_line'] = build_line
if ews.run_tests:
- run_tests_line = "Running: webkit-patch --status-host=example.com build-and-test --no-clean --no-update --test --non-interactive --build-style=%(build_style)s --group=%(group)s --port=%(port)s%(architecture)s\n" % string_replacements
+ run_tests_line = "Running: webkit-patch --status-host=example.com build-and-test --no-clean --no-update --test --non-interactive --build-style=%(build_style)s --group=%(group)s --port=%(port)s%(architecture)s\nMOCK: update_status: %(name)s Passed tests\n" % string_replacements
else:
run_tests_line = ""
string_replacements['run_tests_line'] = run_tests_line
@@ -140,9 +140,13 @@
"begin_work_queue": self._default_begin_work_queue_logs(ews.name),
"process_work_item": """MOCK: update_status: %(name)s Started processing patch
Running: webkit-patch --status-host=example.com clean --port=%(port)s%(architecture)s
+MOCK: update_status: %(name)s Cleaned working directory
Running: webkit-patch --status-host=example.com update --port=%(port)s%(architecture)s
+MOCK: update_status: %(name)s Updated working directory
Running: webkit-patch --status-host=example.com apply-attachment --no-update --non-interactive 10000 --port=%(port)s%(architecture)s
+MOCK: update_status: %(name)s Applied patch
Running: webkit-patch --status-host=example.com check-patch-relevance --quiet --group=%(group)s --port=%(port)s%(architecture)s
+MOCK: update_status: %(name)s Checked relevance of patch
%(build_line)s%(run_tests_line)s%(result_lines)s""" % string_replacements,
"handle_unexpected_error": "Mock error message\n",
"handle_script_error": "ScriptError error message\n\nMOCK output\n",
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
