Title: [223741] trunk/Source/bmalloc
- Revision
- 223741
- Author
- sbar...@apple.com
- Date
- 2017-10-19 20:08:26 -0700 (Thu, 19 Oct 2017)
Log Message
Runtime disable gigacage on iOS because it broke WasmBench
https://bugs.webkit.org/show_bug.cgi?id=178556
Reviewed by Keith Miller.
* bmalloc/Gigacage.cpp:
(Gigacage::shouldBeEnabled):
Modified Paths
Diff
Modified: trunk/Source/bmalloc/ChangeLog (223740 => 223741)
--- trunk/Source/bmalloc/ChangeLog 2017-10-20 02:41:22 UTC (rev 223740)
+++ trunk/Source/bmalloc/ChangeLog 2017-10-20 03:08:26 UTC (rev 223741)
@@ -1,3 +1,13 @@
+2017-10-19 Saam Barati <sbar...@apple.com>
+
+ Runtime disable gigacage on iOS because it broke WasmBench
+ https://bugs.webkit.org/show_bug.cgi?id=178556
+
+ Reviewed by Keith Miller.
+
+ * bmalloc/Gigacage.cpp:
+ (Gigacage::shouldBeEnabled):
+
2017-10-17 Filip Pizlo <fpi...@apple.com>
You can't vmDeallocate null
Modified: trunk/Source/bmalloc/bmalloc/Gigacage.cpp (223740 => 223741)
--- trunk/Source/bmalloc/bmalloc/Gigacage.cpp 2017-10-20 02:41:22 UTC (rev 223740)
+++ trunk/Source/bmalloc/bmalloc/Gigacage.cpp 2017-10-20 03:08:26 UTC (rev 223741)
@@ -240,10 +240,15 @@
bool shouldBeEnabled()
{
static std::once_flag onceFlag;
- static bool cached;
+ static bool cached = false;
std::call_once(
onceFlag,
[] {
+#if BCPU(ARM64)
+ // FIXME: Make WasmBench run with gigacage on iOS and re-enable on ARM64:
+ // https://bugs.webkit.org/show_bug.cgi?id=178557
+ return;
+#endif
bool result = GIGACAGE_ENABLED && !PerProcess<Environment>::get()->isDebugHeapEnabled();
if (!result)
return;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
