Title: [223906] trunk/Source/WebCore
- Revision
- 223906
- Author
- commit-qu...@webkit.org
- Date
- 2017-10-24 11:52:47 -0700 (Tue, 24 Oct 2017)
Log Message
HTMLMediaElement should iterate HTMLTrackElements consistently.
https://bugs.webkit.org/show_bug.cgi?id=178423
rdar://problem/35044967
Patch by Jeremy Jones <jere...@apple.com> on 2017-10-24
Reviewed by Eric Carlson.
No new tests because no expected behavior change.
HTMLMediaElement iterates HTMLTrackElements as children in every place but one, where it iterates them
as descendants. It should always iterate them as children.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::finishParsingChildren):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (223905 => 223906)
--- trunk/Source/WebCore/ChangeLog 2017-10-24 18:50:54 UTC (rev 223905)
+++ trunk/Source/WebCore/ChangeLog 2017-10-24 18:52:47 UTC (rev 223906)
@@ -1,3 +1,19 @@
+2017-10-24 Jeremy Jones <jere...@apple.com>
+
+ HTMLMediaElement should iterate HTMLTrackElements consistently.
+ https://bugs.webkit.org/show_bug.cgi?id=178423
+ rdar://problem/35044967
+
+ Reviewed by Eric Carlson.
+
+ No new tests because no expected behavior change.
+
+ HTMLMediaElement iterates HTMLTrackElements as children in every place but one, where it iterates them
+ as descendants. It should always iterate them as children.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::finishParsingChildren):
+
2017-10-24 Chris Dumez <cdu...@apple.com>
SerializedScriptValue::deserialize() should take ports as a const Vector&
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (223905 => 223906)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-10-24 18:50:54 UTC (rev 223905)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-10-24 18:52:47 UTC (rev 223906)
@@ -840,7 +840,7 @@
m_parsingInProgress = false;
#if ENABLE(VIDEO_TRACK)
- if (descendantsOfType<HTMLTrackElement>(*this).first())
+ if (childrenOfType<HTMLTrackElement>(*this).first())
scheduleDelayedAction(ConfigureTextTracks);
#endif
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
