Title: [223930] trunk/Source/WebCore
- Revision
- 223930
- Author
- aes...@apple.com
- Date
- 2017-10-24 15:05:30 -0700 (Tue, 24 Oct 2017)
Log Message
[WebIDL] Support the ExportMacro attribute for dictionaries
https://bugs.webkit.org/show_bug.cgi?id=178752
Reviewed by Sam Weinig.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateDictionaryHeaderContent):
* bindings/scripts/test/JS/JSTestStandaloneDictionary.h:
* bindings/scripts/test/TestStandaloneDictionary.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (223929 => 223930)
--- trunk/Source/WebCore/ChangeLog 2017-10-24 22:00:53 UTC (rev 223929)
+++ trunk/Source/WebCore/ChangeLog 2017-10-24 22:05:30 UTC (rev 223930)
@@ -1,3 +1,15 @@
+2017-10-24 Andy Estes <aes...@apple.com>
+
+ [WebIDL] Support the ExportMacro attribute for dictionaries
+ https://bugs.webkit.org/show_bug.cgi?id=178752
+
+ Reviewed by Sam Weinig.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateDictionaryHeaderContent):
+ * bindings/scripts/test/JS/JSTestStandaloneDictionary.h:
+ * bindings/scripts/test/TestStandaloneDictionary.idl:
+
2017-10-24 Eric Carlson <eric.carl...@apple.com>
Web Inspector: Enable WebKit logging configuration and display
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (223929 => 223930)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2017-10-24 22:00:53 UTC (rev 223929)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2017-10-24 22:05:30 UTC (rev 223930)
@@ -2222,12 +2222,14 @@
$headerIncludes{"JSDOMConvertDictionary.h"} = 1;
+ my $exportMacro = GetExportMacroForJSClass($dictionary);
+
my $result = "";
$result .= "#if ${conditionalString}\n\n" if $conditionalString;
- $result .= "template<> ${className} convertDictionary<${className}>(JSC::ExecState&, JSC::JSValue);\n\n";
+ $result .= "template<> ${exportMacro}${className} convertDictionary<${className}>(JSC::ExecState&, JSC::JSValue);\n\n";
if ($dictionary->extendedAttributes->{JSGenerateToJSObject}) {
- $result .= "JSC::JSObject* convertDictionaryToJS(JSC::ExecState&, JSDOMGlobalObject&, const ${className}&);\n\n";
+ $result .= "${exportMacro}JSC::JSObject* convertDictionaryToJS(JSC::ExecState&, JSDOMGlobalObject&, const ${className}&);\n\n";
}
$result .= "#endif\n\n" if $conditionalString;
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.h (223929 => 223930)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.h 2017-10-24 22:00:53 UTC (rev 223929)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.h 2017-10-24 22:05:30 UTC (rev 223930)
@@ -28,7 +28,7 @@
namespace WebCore {
-template<> DictionaryImplName convertDictionary<DictionaryImplName>(JSC::ExecState&, JSC::JSValue);
+template<> WEBCORE_EXPORT DictionaryImplName convertDictionary<DictionaryImplName>(JSC::ExecState&, JSC::JSValue);
String convertEnumerationToString(TestStandaloneDictionary::EnumInStandaloneDictionaryFile);
template<> JSC::JSString* convertEnumerationToJS(JSC::ExecState&, TestStandaloneDictionary::EnumInStandaloneDictionaryFile);
Modified: trunk/Source/WebCore/bindings/scripts/test/TestStandaloneDictionary.idl (223929 => 223930)
--- trunk/Source/WebCore/bindings/scripts/test/TestStandaloneDictionary.idl 2017-10-24 22:00:53 UTC (rev 223929)
+++ trunk/Source/WebCore/bindings/scripts/test/TestStandaloneDictionary.idl 2017-10-24 22:05:30 UTC (rev 223930)
@@ -31,6 +31,7 @@
[
ImplementedAs=DictionaryImplName,
Conditional=Condition1,
+ ExportMacro=WEBCORE_EXPORT,
] dictionary TestStandaloneDictionary {
boolean boolMember;
DOMString stringMember;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
