Title: [224640] trunk/Source/WebKit
Revision
224640
Author
megan_gard...@apple.com
Date
2017-11-09 11:30:16 -0800 (Thu, 09 Nov 2017)

Log Message

Clean out unused selection items from UIKitSPI
https://bugs.webkit.org/show_bug.cgi?id=179459

Reviewed by Tim Horton.

Many of these should have been removed from previous commits, but they were missed.
None of these enums or methods are being used by WebKit anymore, and removing them will keep things
clean and allow UIKit to remove things that are not used at all by anyone anymore.

* Platform/spi/ios/UIKitSPI.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (224639 => 224640)


--- trunk/Source/WebKit/ChangeLog	2017-11-09 19:13:36 UTC (rev 224639)
+++ trunk/Source/WebKit/ChangeLog	2017-11-09 19:30:16 UTC (rev 224640)
@@ -1,3 +1,16 @@
+2017-11-09  Megan Gardner  <megan_gard...@apple.com>
+
+        Clean out unused selection items from UIKitSPI
+        https://bugs.webkit.org/show_bug.cgi?id=179459
+
+        Reviewed by Tim Horton.
+
+        Many of these should have been removed from previous commits, but they were missed.
+        None of these enums or methods are being used by WebKit anymore, and removing them will keep things
+        clean and allow UIKit to remove things that are not used at all by anyone anymore.
+
+        * Platform/spi/ios/UIKitSPI.h:
+
 2017-11-09  Christopher Reid  <chris.r...@sony.com>
 
         Use enum classes within FileSystem

Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (224639 => 224640)


--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h	2017-11-09 19:13:36 UTC (rev 224639)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h	2017-11-09 19:30:16 UTC (rev 224640)
@@ -539,10 +539,8 @@
 
 @interface UIWKSelectionAssistant ()
 - (BOOL)shouldHandleSingleTapAtPoint:(CGPoint)point;
-- (void)blockSelectionChangedWithTouch:(UIWKSelectionTouch)touch withFlags:(UIWKSelectionFlags)flags growThreshold:(CGFloat)grow shrinkThreshold:(CGFloat)shrink;
 - (void)selectionChangedWithGestureAt:(CGPoint)point withGesture:(UIWKGestureType)gestureType withState:(UIGestureRecognizerState)gestureState withFlags:(UIWKSelectionFlags)flags;
 - (void)selectionChangedWithTouchAt:(CGPoint)point withSelectionTouch:(UIWKSelectionTouch)touch withFlags:(UIWKSelectionFlags)flags;
-- (void)selectionChangedWithTouchAt:(CGPoint)point withSelectionTouch:(UIWKSelectionTouch)touch;
 - (void)showDictionaryFor:(NSString *)selectedTerm fromRect:(CGRect)presentationRect;
 - (void)showShareSheetFor:(NSString *)selectedTerm fromRect:(CGRect)presentationRect;
 - (void)showTextServiceFor:(NSString *)selectedTerm fromRect:(CGRect)presentationRect;
@@ -550,13 +548,6 @@
 @property (nonatomic, readonly) UILongPressGestureRecognizer *selectionLongPressRecognizer;
 @end
 
-typedef NS_ENUM(NSInteger, UIWKHandlePosition) {
-    UIWKHandleTop = 0,
-    UIWKHandleRight = 1,
-    UIWKHandleBottom = 2,
-    UIWKHandleLeft = 3,
-};
-
 @interface UIWKAutocorrectionRects : NSObject
 @end
 
@@ -583,7 +574,6 @@
 - (void)selectionChangedWithGestureAt:(CGPoint)point withGesture:(UIWKGestureType)gestureType withState:(UIGestureRecognizerState)gestureState withFlags:(UIWKSelectionFlags)flags;
 - (void)showDictionaryFor:(NSString *)selectedTerm fromRect:(CGRect)presentationRect;
 - (void)selectionChangedWithTouchAt:(CGPoint)point withSelectionTouch:(UIWKSelectionTouch)touch withFlags:(UIWKSelectionFlags)flags;
-- (void)selectionChangedWithTouchAt:(CGPoint)point withSelectionTouch:(UIWKSelectionTouch)touch;
 - (void)showTextStyleOptions;
 - (void)hideTextStyleOptions;
 - (void)lookup:(NSString *)textWithContext withRange:(NSRange)range fromRect:(CGRect)presentationRect;
@@ -598,7 +588,6 @@
 
 @protocol UIWKInteractionViewProtocol
 - (void)changeSelectionWithGestureAt:(CGPoint)point withGesture:(UIWKGestureType)gestureType withState:(UIGestureRecognizerState)state;
-
 - (void)changeSelectionWithTouchAt:(CGPoint)point withSelectionTouch:(UIWKSelectionTouch)touch baseIsStart:(BOOL)baseIsStart withFlags:(UIWKSelectionFlags)flags;
 - (void)changeSelectionWithTouchesFrom:(CGPoint)from to:(CGPoint)to withGesture:(UIWKGestureType)gestureType withState:(UIGestureRecognizerState)gestureState;
 - (CGRect)textFirstRect;
@@ -636,11 +625,6 @@
 - (CGRect)unobscuredContentRect;
 @end
 
-typedef enum {
-    UIWebSelectionModeWeb = 0,
-    UIWebSelectionModeTextOnly = 1,
-} UIWebSelectionMode;
-
 @protocol UIWebFormAccessoryDelegate;
 
 @interface UIWebFormAccessory : UIInputView
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to