Title: [225317] trunk/LayoutTests
Revision
225317
Author
grao...@webkit.org
Date
2017-11-29 22:15:24 -0800 (Wed, 29 Nov 2017)

Log Message

Move modern media controls test expectations from ios-simulator to ios
https://bugs.webkit.org/show_bug.cgi?id=180158

Reviewed by Dean Jackson.

We shouldn't be using the ios-simulator platform for these, ios is the right one.

* platform/ios-simulator/TestExpectations:
* platform/ios/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (225316 => 225317)


--- trunk/LayoutTests/ChangeLog	2017-11-30 06:13:40 UTC (rev 225316)
+++ trunk/LayoutTests/ChangeLog	2017-11-30 06:15:24 UTC (rev 225317)
@@ -1,3 +1,15 @@
+2017-11-29  Antoine Quint  <grao...@apple.com>
+
+        Move modern media controls test expectations from ios-simulator to ios
+        https://bugs.webkit.org/show_bug.cgi?id=180158
+
+        Reviewed by Dean Jackson.
+
+        We shouldn't be using the ios-simulator platform for these, ios is the right one.
+
+        * platform/ios-simulator/TestExpectations:
+        * platform/ios/TestExpectations:
+
 2017-11-29  Chris Dumez  <cdu...@apple.com>
 
         LayoutTest http/tests/workers/service/registration-clear-redundant-worker.html is a flaky failure

Modified: trunk/LayoutTests/platform/ios/TestExpectations (225316 => 225317)


--- trunk/LayoutTests/platform/ios/TestExpectations	2017-11-30 06:13:40 UTC (rev 225316)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2017-11-30 06:15:24 UTC (rev 225317)
@@ -3070,9 +3070,6 @@
 svg/W3C-SVG-1.1/text-intro-04-t.svg [ Failure ]
 svg/custom/acid3-test-77.html [ Failure ]
 
-# <rdar://problem/33731086>
-media/modern-media-controls/time-labels-support/elapsed-time.html [ Skip ]
-
 # <rdar://problem/33381269> REGRESSION: Multiple Layout test from webgl/1.0.2/conformance are timing out.
 webgl/1.0.2/conformance/attribs/gl-vertex-attrib-zero-issues.html [ Skip  ]
 webgl/1.0.2/conformance/ogles/GL/acos/acos_001_to_006.html [ Skip  ]
@@ -3175,3 +3172,106 @@
 webkit.org/b/179773 imported/w3c/web-platform-tests/fetch/api/abort/serviceworker-intercepted.https.html [ Pass Failure ]
 
 webkit.org/b/179784 svg/in-html/by-reference.html [ Failure Timeout ]
+
+# The modern-media-controls tests are disabled due to past flakiness and some major code changes.
+# As a result, a host of tests need to be updated and being turned on selectively here.
+media/modern-media-controls/airplay-button [ Pass ]
+media/modern-media-controls/airplay-placard [ Pass ]
+media/modern-media-controls/audio [ Pass ]
+media/modern-media-controls/background-tint [ Pass ]
+media/modern-media-controls/button [ Pass ]
+media/modern-media-controls/buttons-container [ Pass ]
+media/modern-media-controls/controls-bar [ Pass ]
+media/modern-media-controls/controls-visibility-support [ Pass ]
+media/modern-media-controls/css [ Pass ]
+media/modern-media-controls/forward-button [ Pass ]
+media/modern-media-controls/fullscreen-button [ Pass ]
+media/modern-media-controls/fullscreen-support [ Pass ]
+media/modern-media-controls/icon-service [ Pass ]
+media/modern-media-controls/invalid-placard [ Pass ]
+media/modern-media-controls/layout-item [ Pass ]
+media/modern-media-controls/layout-node [ Pass ]
+media/modern-media-controls/localized-strings [ Pass ]
+media/modern-media-controls/media-controller [ Pass ]
+media/modern-media-controls/media-controls/media-controls-display-above-captions.html [ Pass ]
+media/modern-media-controls/media-documents [ Pass ]
+media/modern-media-controls/mute-button [ Pass ]
+media/modern-media-controls/mute-support [ Pass ]
+media/modern-media-controls/pip-button [ Pass ]
+media/modern-media-controls/pip-placard [ Pass ]
+media/modern-media-controls/pip-support/ipad [ Pass ]
+media/modern-media-controls/placard [ Pass ]
+media/modern-media-controls/placard-support [ Pass ]
+media/modern-media-controls/play-pause-button [ Pass ]
+media/modern-media-controls/playback-support [ Pass ]
+media/modern-media-controls/rewind-button [ Pass ]
+media/modern-media-controls/scheduler [ Pass ]
+media/modern-media-controls/scrubber [ Pass ]
+media/modern-media-controls/scrubber-support [ Pass ]
+media/modern-media-controls/skip-back-button [ Pass ]
+media/modern-media-controls/skip-forward-button [ Pass ]
+media/modern-media-controls/slider [ Pass ]
+media/modern-media-controls/status-label [ Pass ]
+media/modern-media-controls/status-support [ Pass ]
+media/modern-media-controls/time-control [ Pass ]
+media/modern-media-controls/time-label [ Pass ]
+media/modern-media-controls/time-labels-support [ Pass ]
+
+# accessibilityController.role cannot be tested on iOS
+media/modern-media-controls/time-label/time-label.html [ Skip ]
+media/modern-media-controls/tracks-button [ Pass ]
+
+# AirPlay cannot be tested on iOS
+webkit.org/b/166062 media/modern-media-controls/airplay-support [ Skip ]
+webkit.org/b/166062 media/modern-media-controls/audio/audio-controls-buttons.html [ Skip ]
+webkit.org/b/166062 media/modern-media-controls/placard-support/placard-support-airplay.html [ Skip ]
+
+# These tests use touch events and don't work in OpenSource
+media/modern-media-controls/button/button.html [ Skip ]
+media/modern-media-controls/button/button-active-state.html [ Skip ]
+media/modern-media-controls/fullscreen-support/fullscreen-support-press.html [ Skip ]
+media/modern-media-controls/media-controller/ios/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html [ Skip ]
+media/modern-media-controls/media-controller/ios/media-controller-stop-updates-in-fullscreen.html [ Skip ]
+media/modern-media-controls/mute-support/mute-support-press-on-button.html [ Skip ]
+media/modern-media-controls/pip-support/ipad/pip-support-tap.html [ Skip ]
+media/modern-media-controls/placard-support/ipad [ Skip ]
+media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html [ Skip ]
+
+# There is no focus state for on iOS
+media/modern-media-controls/button/button-focus-state.html [ Skip ]
+
+# These tests rely on fullscreen which do not use the WebKit media controls on iOS
+media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-parent-element.html [ Skip ]
+media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html [ Skip ]
+media/modern-media-controls/css/webkit-cursor-visibility-auto-hide.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-fade-controls-when-entering-fullscreen.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-fullscreen-change.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html [ Skip ]
+media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html [ Skip ]
+
+# These tests specifically test iOS-only media controls features
+media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-button-padding.html [ Pass ]
+
+# These tests are designed to work only on macOS
+media/modern-media-controls/button/button-click-on-edges.html [ Skip ]
+media/modern-media-controls/placard-support/placard-support-pip.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause-fullscreen.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-click-on-video-background-to-dismiss-tracks-panel-should-not-toggle-playback.html [ Skip ]
+media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html [ Skip ]
+media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html [ Skip ]
+media/modern-media-controls/media-documents/media-document-video-mac-sizing.html [ Skip ]
+media/modern-media-controls/playback-support/playback-support-button-click.html [ Skip ]
+media/modern-media-controls/scrubber-support/scrubber-support-click.html [ Skip ]
+media/modern-media-controls/scrubber-support/scrubber-support-drag.html [ Skip ]
+
+webkit.org/b/178127 media/modern-media-controls/media-controller/media-controller-video-with-only-audio.html [ Skip ]
+
+# <rdar://problem/33731086>
+media/modern-media-controls/time-labels-support/elapsed-time.html [ Skip ]

Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (225316 => 225317)


--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2017-11-30 06:13:40 UTC (rev 225316)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2017-11-30 06:15:24 UTC (rev 225317)
@@ -38,106 +38,6 @@
 
 transforms/hittest-translated-content-off-to-infinity-and-back.html [ Pass ImageOnlyFailure ]
 
-# The modern-media-controls tests are disabled due to past flakiness and some major code changes.
-# As a result, a host of tests need to be updated and being turned on selectively here.
-media/modern-media-controls/airplay-button [ Pass ]
-media/modern-media-controls/airplay-placard [ Pass ]
-media/modern-media-controls/audio [ Pass ]
-media/modern-media-controls/background-tint [ Pass ]
-media/modern-media-controls/button [ Pass ]
-media/modern-media-controls/buttons-container [ Pass ]
-media/modern-media-controls/controls-bar [ Pass ]
-media/modern-media-controls/controls-visibility-support [ Pass ]
-media/modern-media-controls/css [ Pass ]
-media/modern-media-controls/forward-button [ Pass ]
-media/modern-media-controls/fullscreen-button [ Pass ]
-media/modern-media-controls/fullscreen-support [ Pass ]
-media/modern-media-controls/icon-service [ Pass ]
-media/modern-media-controls/invalid-placard [ Pass ]
-media/modern-media-controls/layout-item [ Pass ]
-media/modern-media-controls/layout-node [ Pass ]
-media/modern-media-controls/localized-strings [ Pass ]
-media/modern-media-controls/media-controller [ Pass ]
-media/modern-media-controls/media-controls/media-controls-display-above-captions.html [ Pass ]
-media/modern-media-controls/media-documents [ Pass ]
-media/modern-media-controls/mute-button [ Pass ]
-media/modern-media-controls/mute-support [ Pass ]
-media/modern-media-controls/pip-button [ Pass ]
-media/modern-media-controls/pip-placard [ Pass ]
-media/modern-media-controls/pip-support/ipad [ Pass ]
-media/modern-media-controls/placard [ Pass ]
-media/modern-media-controls/placard-support [ Pass ]
-media/modern-media-controls/play-pause-button [ Pass ]
-media/modern-media-controls/playback-support [ Pass ]
-media/modern-media-controls/rewind-button [ Pass ]
-media/modern-media-controls/scheduler [ Pass ]
-media/modern-media-controls/scrubber [ Pass ]
-media/modern-media-controls/scrubber-support [ Pass ]
-media/modern-media-controls/skip-back-button [ Pass ]
-media/modern-media-controls/skip-forward-button [ Pass ]
-media/modern-media-controls/slider [ Pass ]
-media/modern-media-controls/status-label [ Pass ]
-media/modern-media-controls/status-support [ Pass ]
-media/modern-media-controls/time-control [ Pass ]
-media/modern-media-controls/time-label [ Pass ]
-media/modern-media-controls/time-labels-support [ Pass ]
-
-# accessibilityController.role cannot be tested on iOS
-media/modern-media-controls/time-label/time-label.html [ Skip ]
-media/modern-media-controls/tracks-button [ Pass ]
-
-# AirPlay cannot be tested on iOS
-webkit.org/b/166062 media/modern-media-controls/airplay-support [ Skip ]
-webkit.org/b/166062 media/modern-media-controls/audio/audio-controls-buttons.html [ Skip ]
-webkit.org/b/166062 media/modern-media-controls/placard-support/placard-support-airplay.html [ Skip ]
-
-# These tests use touch events and don't work in OpenSource
-media/modern-media-controls/button/button.html [ Skip ]
-media/modern-media-controls/button/button-active-state.html [ Skip ]
-media/modern-media-controls/fullscreen-support/fullscreen-support-press.html [ Skip ]
-media/modern-media-controls/media-controller/ios/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html [ Skip ]
-media/modern-media-controls/media-controller/ios/media-controller-stop-updates-in-fullscreen.html [ Skip ]
-media/modern-media-controls/mute-support/mute-support-press-on-button.html [ Skip ]
-media/modern-media-controls/pip-support/ipad/pip-support-tap.html [ Skip ]
-media/modern-media-controls/placard-support/ipad [ Skip ]
-media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html [ Skip ]
-
-# There is no focus state for on iOS
-media/modern-media-controls/button/button-focus-state.html [ Skip ]
-
-# These tests rely on fullscreen which do not use the WebKit media controls on iOS
-media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-parent-element.html [ Skip ]
-media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html [ Skip ]
-media/modern-media-controls/css/webkit-cursor-visibility-auto-hide.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-fade-controls-when-entering-fullscreen.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-fullscreen-change.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html [ Skip ]
-media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html [ Skip ]
-
-# These tests specifically test iOS-only media controls features
-media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-button-padding.html [ Pass ]
-
-# These tests are designed to work only on macOS
-media/modern-media-controls/button/button-click-on-edges.html [ Skip ]
-media/modern-media-controls/placard-support/placard-support-pip.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause-fullscreen.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-click-on-video-background-to-dismiss-tracks-panel-should-not-toggle-playback.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html [ Skip ]
-media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html [ Skip ]
-media/modern-media-controls/media-documents/media-document-video-mac-sizing.html [ Skip ]
-media/modern-media-controls/playback-support/playback-support-button-click.html [ Skip ]
-media/modern-media-controls/scrubber-support/scrubber-support-click.html [ Skip ]
-media/modern-media-controls/scrubber-support/scrubber-support-drag.html [ Skip ]
-
-webkit.org/b/178127 media/modern-media-controls/media-controller/media-controller-video-with-only-audio.html [ Skip ]
-
 webkit.org/b/172965 media/track/track-cue-overlap-snap-to-lines-not-set.html [ Failure ]
 
 webkit.org/b/156718 storage/websql/alter-to-info-table.html [ Failure ]
@@ -158,6 +58,3 @@
 
 # This test requires Skia, which isn't available on iOS.
 webkit.org/b/174079 fast/text/variations/skia-postscript-name.html [ ImageOnlyFailure ]
-
-# <rdar://problem/33731086>
-media/modern-media-controls/time-labels-support/elapsed-time.html [ Skip ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to