Title: [226229] trunk/LayoutTests/imported/w3c
- Revision
- 226229
- Author
- commit-qu...@webkit.org
- Date
- 2017-12-21 10:38:24 -0800 (Thu, 21 Dec 2017)
Log Message
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-xhr.https.html is failing one test
https://bugs.webkit.org/show_bug.cgi?id=181072
Patch by Youenn Fablet <you...@apple.com> on 2017-12-21
Reviewed by Alex Christensen.
Test loads twice the same resource but the memory cache intercepts the second load and provides the first response.
Fixing the test by mandating the response to not be cacheable.
* web-platform-tests/service-workers/service-worker/fetch-request-xhr.https-expected.txt:
* web-platform-tests/service-workers/service-worker/resources/fetch-request-xhr-worker.js:
(event.respondWith.new.Promise):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (226228 => 226229)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2017-12-21 18:28:21 UTC (rev 226228)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2017-12-21 18:38:24 UTC (rev 226229)
@@ -1,3 +1,17 @@
+2017-12-21 Youenn Fablet <you...@apple.com>
+
+ LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-xhr.https.html is failing one test
+ https://bugs.webkit.org/show_bug.cgi?id=181072
+
+ Reviewed by Alex Christensen.
+
+ Test loads twice the same resource but the memory cache intercepts the second load and provides the first response.
+ Fixing the test by mandating the response to not be cacheable.
+
+ * web-platform-tests/service-workers/service-worker/fetch-request-xhr.https-expected.txt:
+ * web-platform-tests/service-workers/service-worker/resources/fetch-request-xhr-worker.js:
+ (event.respondWith.new.Promise):
+
2017-12-20 Youenn Fablet <you...@apple.com>
Support service worker interception of request with blob body
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-xhr.https-expected.txt (226228 => 226229)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-xhr.https-expected.txt 2017-12-21 18:28:21 UTC (rev 226228)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-xhr.https-expected.txt 2017-12-21 18:38:24 UTC (rev 226229)
@@ -9,7 +9,7 @@
PASS FetchEvent#request.method is set to XHR method
PASS XHR using OPTIONS method
FAIL XHR with form data promise_test: Unhandled rejection with value: object "Error: assert_equals: expected (string) "POST" but got (undefined) undefined"
-FAIL XHR with mode/credentials set promise_test: Unhandled rejection with value: object "Error: assert_equals: expected "include" but got "same-origin""
+PASS XHR with mode/credentials set
PASS XHR to data URL
PASS restore global state
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/fetch-request-xhr-worker.js (226228 => 226229)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/fetch-request-xhr-worker.js 2017-12-21 18:28:21 UTC (rev 226228)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/fetch-request-xhr-worker.js 2017-12-21 18:38:24 UTC (rev 226229)
@@ -16,7 +16,7 @@
credentials: event.request.credentials,
headers: headers,
body: result
- })));
+ }), { headers : [["Cache-Control", "no-cache"]] } ));
});
}));
});
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
