Title: [226996] trunk/Source/WebInspectorUI
- Revision
- 226996
- Author
- nvasil...@apple.com
- Date
- 2018-01-16 12:54:04 -0800 (Tue, 16 Jan 2018)
Log Message
Web Inspector: Styles: pressing down key should select first item from completion list when focusing on empty value
https://bugs.webkit.org/show_bug.cgi?id=181633
<rdar://problem/36501797>
Reviewed by Joseph Pecoraro.
* UserInterface/Views/SpreadsheetTextField.js:
(WI.SpreadsheetTextField.prototype._updateCompletions):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (226995 => 226996)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-01-16 20:31:54 UTC (rev 226995)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-01-16 20:54:04 UTC (rev 226996)
@@ -1,5 +1,16 @@
2018-01-16 Nikita Vasilyev <nvasil...@apple.com>
+ Web Inspector: Styles: pressing down key should select first item from completion list when focusing on empty value
+ https://bugs.webkit.org/show_bug.cgi?id=181633
+ <rdar://problem/36501797>
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/SpreadsheetTextField.js:
+ (WI.SpreadsheetTextField.prototype._updateCompletions):
+
+2018-01-16 Nikita Vasilyev <nvasil...@apple.com>
+
Web Inspector: Styles Redesign: Long value causes bad wrapping
https://bugs.webkit.org/show_bug.cgi?id=181618
<rdar://problem/36485175>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js (226995 => 226996)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js 2018-01-16 20:31:54 UTC (rev 226995)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js 2018-01-16 20:54:04 UTC (rev 226996)
@@ -381,11 +381,11 @@
this._suggestionsView.show(caretRect);
}
- // Select first item and call completionSuggestionsSelectedCompletion.
this._suggestionsView.selectedIndex = NaN;
- this._suggestionsView.selectNext();
-
- if (!completionPrefix)
+ if (completionPrefix) {
+ // Select first item and call completionSuggestionsSelectedCompletion.
+ this._suggestionsView.selectNext();
+ } else
this.suggestionHint = "";
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
