Title: [228001] trunk
- Revision
- 228001
- Author
- commit-qu...@webkit.org
- Date
- 2018-02-02 02:53:30 -0800 (Fri, 02 Feb 2018)
Log Message
[GTK] fast/events/message-channel-gc-4.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=182104
Patch by Fujii Hironori <hironori.fu...@sony.com> on 2018-02-02
Reviewed by Carlos Garcia Campos.
Source/WTF:
RELEASE_ASSERT of ThreadSpecific::set fails because
RunLoop::current is called even in GC thread since r227275.
* wtf/RunLoop.cpp:
(WTF::RunLoop::current):
Let the second template argument of ThreadSpecific CanBeGCThread::True.
LayoutTests:
* platform/gtk/TestExpectations:
Unmarked fast/events/message-channel-gc-4.html and fast/workers/worker-cloneport.html.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (228000 => 228001)
--- trunk/LayoutTests/ChangeLog 2018-02-02 09:24:22 UTC (rev 228000)
+++ trunk/LayoutTests/ChangeLog 2018-02-02 10:53:30 UTC (rev 228001)
@@ -1,3 +1,13 @@
+2018-02-02 Fujii Hironori <hironori.fu...@sony.com>
+
+ [GTK] fast/events/message-channel-gc-4.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=182104
+
+ Reviewed by Carlos Garcia Campos.
+
+ * platform/gtk/TestExpectations:
+ Unmarked fast/events/message-channel-gc-4.html and fast/workers/worker-cloneport.html.
+
2018-02-01 Chris Dumez <cdu...@apple.com>
When SW install fails, null out registration.installing before setting worker state to "redundant"
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (228000 => 228001)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2018-02-02 09:24:22 UTC (rev 228000)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2018-02-02 10:53:30 UTC (rev 228001)
@@ -1919,10 +1919,6 @@
webkit.org/b/181766 imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-br-element/br-bidi-in-inline-ancestors.html [ Pass Timeout ]
webkit.org/b/181767 fast/hidpi/filters-hue-rotate.html [ Pass ImageOnlyFailure ]
-webkit.org/b/182104 fast/events/message-channel-gc-4.html [ Pass Crash ]
-
-webkit.org/b/182105 fast/workers/worker-cloneport.html [ Pass Crash ]
-
webkit.org/b/179947 imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/bdi-auto-dir-default.html [ Pass Timeout ]
webkit.org/b/182364 imported/w3c/web-platform-tests/fetch/security/embedded-credentials.tentative.sub.html [ Pass Timeout Crash ]
Modified: trunk/Source/WTF/ChangeLog (228000 => 228001)
--- trunk/Source/WTF/ChangeLog 2018-02-02 09:24:22 UTC (rev 228000)
+++ trunk/Source/WTF/ChangeLog 2018-02-02 10:53:30 UTC (rev 228001)
@@ -1,3 +1,17 @@
+2018-02-02 Fujii Hironori <hironori.fu...@sony.com>
+
+ [GTK] fast/events/message-channel-gc-4.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=182104
+
+ Reviewed by Carlos Garcia Campos.
+
+ RELEASE_ASSERT of ThreadSpecific::set fails because
+ RunLoop::current is called even in GC thread since r227275.
+
+ * wtf/RunLoop.cpp:
+ (WTF::RunLoop::current):
+ Let the second template argument of ThreadSpecific CanBeGCThread::True.
+
2018-02-01 Michael Catanzaro <mcatanz...@igalia.com>
[WPE][GTK] Make RunLoop::TimerBase robust to its own deletion inside its source callback
Modified: trunk/Source/WTF/wtf/RunLoop.cpp (228000 => 228001)
--- trunk/Source/WTF/wtf/RunLoop.cpp 2018-02-02 09:24:22 UTC (rev 228000)
+++ trunk/Source/WTF/wtf/RunLoop.cpp 2018-02-02 10:53:30 UTC (rev 228001)
@@ -58,7 +58,7 @@
RunLoop& RunLoop::current()
{
- static NeverDestroyed<ThreadSpecific<Holder>> runLoopHolder;
+ static NeverDestroyed<ThreadSpecific<Holder, CanBeGCThread::True>> runLoopHolder;
return runLoopHolder.get()->runLoop();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
