Diff
Modified: trunk/LayoutTests/ChangeLog (228096 => 228097)
--- trunk/LayoutTests/ChangeLog 2018-02-05 16:30:02 UTC (rev 228096)
+++ trunk/LayoutTests/ChangeLog 2018-02-05 16:33:33 UTC (rev 228097)
@@ -1,3 +1,35 @@
+2018-02-05 Antoine Quint <grao...@apple.com>
+
+ [Modern Media Controls] Turn media/modern-media-controls tests back on by default
+ https://bugs.webkit.org/show_bug.cgi?id=182482
+
+ Reviewed by Eric Carlson.
+
+ After updating a significant amount of tests under media/modern-media-controls over the last week, we can stop skipping
+ tests in this directory by default, and instead skip tests that do not apply on a per-platform basis. This patch does that
+ along with fixing a few remaining tests and adding some more for the new behavior of display 3, 4, 5 or 6 digits for time
+ labels depending on the overall video duration.
+
+ * TestExpectations:
+ * http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast-expected.txt:
+ * http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html:
+ * http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click-expected.txt:
+ * http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html:
+ * http/tests/media/modern-media-controls/status-support/status-support-loading-expected.txt:
+ * http/tests/media/modern-media-controls/status-support/status-support-loading.html:
+ * http/tests/media/modern-media-controls/time-control/1-to-10-hours-expected.txt: Added.
+ * http/tests/media/modern-media-controls/time-control/1-to-10-hours.html: Added.
+ * http/tests/media/modern-media-controls/time-control/10-hours-or-more-expected.txt: Added.
+ * http/tests/media/modern-media-controls/time-control/10-hours-or-more.html: Added.
+ * http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour-expected.txt: Added.
+ * http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour.html: Added.
+ * http/tests/media/modern-media-controls/time-control/less-than-10-minutes-expected.txt: Renamed from LayoutTests/http/tests/media/modern-media-controls/time-labels-support/long-time-expected.txt.
+ * http/tests/media/modern-media-controls/time-control/less-than-10-minutes.html: Renamed from LayoutTests/http/tests/media/modern-media-controls/time-labels-support/long-time.html.
+ * media/modern-media-controls/scrubber-support/scrubber-support-drag.html: Make this test more reliable by going a little further
+ left of the slider's left-most point to ensure we always get a 0-value.
+ * platform/ios/TestExpectations:
+ * platform/mac/TestExpectations:
+
2018-02-05 Antti Koivisto <an...@apple.com>
Crash on sfgate.com because mismatching link preload types
Modified: trunk/LayoutTests/TestExpectations (228096 => 228097)
--- trunk/LayoutTests/TestExpectations 2018-02-05 16:30:02 UTC (rev 228096)
+++ trunk/LayoutTests/TestExpectations 2018-02-05 16:33:33 UTC (rev 228097)
@@ -1593,10 +1593,6 @@
# FileAPI
webkit.org/b/172099 imported/w3c/web-platform-tests/FileAPI/url/url_xmlhttprequest_img.html [ ImageOnlyFailure ]
-# All modern-media-controls tests are disabled for the time being.
-http/tests/media/modern-media-controls [ Skip ]
-media/modern-media-controls [ Skip ]
-
# Secure Contexts tests that timeout
imported/w3c/web-platform-tests/secure-contexts/basic-dedicated-worker.html [ Skip ]
imported/w3c/web-platform-tests/secure-contexts/basic-dedicated-worker.https.html [ Skip ]
Modified: trunk/LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast-expected.txt (228096 => 228097)
--- trunk/LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast-expected.txt 2018-02-05 16:30:02 UTC (rev 228096)
+++ trunk/LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast-expected.txt 2018-02-05 16:33:33 UTC (rev 228097)
@@ -7,7 +7,7 @@
PASS mediaController.controls.rewindButton.enabled is false
PASS mediaController.controls.forwardButton.enabled is false
PASS mediaController.controls.timeControl.parent is null
-PASS mediaController.controls.statusLabel.parent is mediaController.controls.controlsBar
+PASS mediaController.controls.statusLabel.parent is mediaController.controls.bottomControlsBar
PASS successfullyParsed is true
Modified: trunk/LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html (228096 => 228097)
--- trunk/LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html 2018-02-05 16:30:02 UTC (rev 228096)
+++ trunk/LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html 2018-02-05 16:33:33 UTC (rev 228097)
@@ -2,7 +2,7 @@
<script src=""
<script src=""
<body>
-<video src="" style="width: 800px;" autoplay></video>
+<video src="" style="width: 400px; height: 300px;" autoplay></video>
<div id="shadow"></div>
<script type="text/_javascript_">
@@ -22,7 +22,7 @@
shouldBeFalse("mediaController.controls.rewindButton.enabled");
shouldBeFalse("mediaController.controls.forwardButton.enabled");
shouldBe("mediaController.controls.timeControl.parent", "null");
- shouldBe("mediaController.controls.statusLabel.parent", "mediaController.controls.controlsBar");
+ shouldBe("mediaController.controls.statusLabel.parent", "mediaController.controls.bottomControlsBar");
debug("");
media.remove();
@@ -35,6 +35,7 @@
media.pause();
const button = document.body.appendChild(document.createElement("button"));
+ button.textContent = "Enter fullscreen";
button.addEventListener("click", event => media.webkitEnterFullscreen());
pressOnElement(button);
button.remove();
Modified: trunk/LayoutTests/http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click-expected.txt (228096 => 228097)
--- trunk/LayoutTests/http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click-expected.txt 2018-02-05 16:30:02 UTC (rev 228096)
+++ trunk/LayoutTests/http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click-expected.txt 2018-02-05 16:33:33 UTC (rev 228097)
@@ -3,10 +3,10 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-Media seeked to currentTime = 50
+Media seeked to currentTime = 25
Dispatching click event to the skip back button
-Media seeked to currentTime = 20
+Media seeked to currentTime = 10
Dispatching click event to the skip back button
Media seeked to currentTime = 0
Modified: trunk/LayoutTests/http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html (228096 => 228097)
--- trunk/LayoutTests/http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html 2018-02-05 16:30:02 UTC (rev 228096)
+++ trunk/LayoutTests/http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html 2018-02-05 16:33:33 UTC (rev 228097)
@@ -36,7 +36,7 @@
{
media.removeEventListener("canplaythrough", mediaCanPlay);
media.addEventListener("seeked", mediaDidSeek);
- media.currentTime = 50;
+ media.currentTime = 25;
}
media.addEventListener("canplaythrough", mediaCanPlay);
Modified: trunk/LayoutTests/http/tests/media/modern-media-controls/status-support/status-support-loading-expected.txt (228096 => 228097)
--- trunk/LayoutTests/http/tests/media/modern-media-controls/status-support/status-support-loading-expected.txt 2018-02-05 16:30:02 UTC (rev 228096)
+++ trunk/LayoutTests/http/tests/media/modern-media-controls/status-support/status-support-loading-expected.txt 2018-02-05 16:33:33 UTC (rev 228097)
@@ -1,10 +1,14 @@
-Testing the StatusSupport behavior for the loading state.
+Testing the TimeControl behavior for the loading state.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS mediaController.controls.statusLabel.text is "Loading"
+TimeControl should not be in loading state by default.
+PASS mediaController.controls.timeControl.loading is false
+Media is stalled, TimeControl should now be in the loading state.
+PASS mediaController.controls.timeControl.loading is true
+
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/http/tests/media/modern-media-controls/status-support/status-support-loading.html (228096 => 228097)
--- trunk/LayoutTests/http/tests/media/modern-media-controls/status-support/status-support-loading.html 2018-02-05 16:30:02 UTC (rev 228096)
+++ trunk/LayoutTests/http/tests/media/modern-media-controls/status-support/status-support-loading.html 2018-02-05 16:33:33 UTC (rev 228097)
@@ -7,15 +7,20 @@
window.jsTestIsAsync = true;
-description("Testing the <code>StatusSupport</code> behavior for the loading state.");
+description("Testing the <code>TimeControl</code> behavior for the loading state.");
const shadowRoot = document.querySelector("div#shadow").attachShadow({ mode: "open" });
const media = document.querySelector("video");
const mediaController = createControls(shadowRoot, media, null);
+debug("TimeControl should not be in loading state by default.");
+shouldBeFalse("mediaController.controls.timeControl.loading")
+
media.addEventListener("stalled", function() {
- shouldBeEqualToString("mediaController.controls.statusLabel.text", "Loading");
debug("");
+ debug("Media is stalled, TimeControl should now be in the loading state.");
+ shouldBeTrue("mediaController.controls.timeControl.loading");
+ debug("");
shadowRoot.host.remove();
media.remove();
finishJSTest();
Copied: trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/1-to-10-hours-expected.txt (from rev 228096, trunk/LayoutTests/http/tests/media/modern-media-controls/time-labels-support/long-time-expected.txt) (0 => 228097)
--- trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/1-to-10-hours-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/1-to-10-hours-expected.txt 2018-02-05 16:33:33 UTC (rev 228097)
@@ -0,0 +1,11 @@
+Testing the display of time labels with a video that is over 1 hour but less than 10.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS mediaController.controls.timeControl.elapsedTimeLabel.element.textContent became "0:00:05"
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/1-to-10-hours.html (from rev 228096, trunk/LayoutTests/http/tests/media/modern-media-controls/time-labels-support/long-time.html) (0 => 228097)
--- trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/1-to-10-hours.html (rev 0)
+++ trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/1-to-10-hours.html 2018-02-05 16:33:33 UTC (rev 228097)
@@ -0,0 +1,29 @@
+<script src=""
+<script src=""
+<body>
+<video src="" style="width: 320px; height: 240px;" controls autoplay></video>
+<div id="shadow"></div>
+<script type="text/_javascript_">
+
+window.jsTestIsAsync = true;
+
+description("Testing the display of time labels with a video that is over 1 hour but less than 10.");
+
+const shadowRoot = document.querySelector("div#shadow").attachShadow({ mode: "open" });
+const media = document.querySelector("video");
+const mediaController = createControls(shadowRoot, media, null);
+
+media.addEventListener("play", () => {
+ media.pause();
+ media.currentTime = 5;
+ shouldBecomeEqualToString("mediaController.controls.timeControl.elapsedTimeLabel.element.textContent", "0:00:05", () => {
+ debug("");
+ shadowRoot.host.remove();
+ media.remove();
+ finishJSTest();
+ });
+});
+
+</script>
+<script src=""
+</body>
Copied: trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/10-hours-or-more-expected.txt (from rev 228096, trunk/LayoutTests/http/tests/media/modern-media-controls/time-labels-support/long-time-expected.txt) (0 => 228097)
--- trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/10-hours-or-more-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/10-hours-or-more-expected.txt 2018-02-05 16:33:33 UTC (rev 228097)
@@ -0,0 +1,11 @@
+Testing the display of time labels with a video that is over 10 hours.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS mediaController.controls.timeControl.elapsedTimeLabel.element.textContent became "00:00:05"
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/10-hours-or-more.html (from rev 228096, trunk/LayoutTests/http/tests/media/modern-media-controls/time-labels-support/long-time.html) (0 => 228097)
--- trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/10-hours-or-more.html (rev 0)
+++ trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/10-hours-or-more.html 2018-02-05 16:33:33 UTC (rev 228097)
@@ -0,0 +1,29 @@
+<script src=""
+<script src=""
+<body>
+<video src="" style="width: 320px; height: 240px;" controls autoplay></video>
+<div id="shadow"></div>
+<script type="text/_javascript_">
+
+window.jsTestIsAsync = true;
+
+description("Testing the display of time labels with a video that is over 10 hours.");
+
+const shadowRoot = document.querySelector("div#shadow").attachShadow({ mode: "open" });
+const media = document.querySelector("video");
+const mediaController = createControls(shadowRoot, media, null);
+
+media.addEventListener("play", () => {
+ media.pause();
+ media.currentTime = 5;
+ shouldBecomeEqualToString("mediaController.controls.timeControl.elapsedTimeLabel.element.textContent", "00:00:05", () => {
+ debug("");
+ shadowRoot.host.remove();
+ media.remove();
+ finishJSTest();
+ });
+});
+
+</script>
+<script src=""
+</body>
Copied: trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour-expected.txt (from rev 228096, trunk/LayoutTests/http/tests/media/modern-media-controls/time-labels-support/long-time-expected.txt) (0 => 228097)
--- trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour-expected.txt 2018-02-05 16:33:33 UTC (rev 228097)
@@ -0,0 +1,11 @@
+Testing the display of time labels with a video that is 10 minutes or more but less than 1 hour.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS mediaController.controls.timeControl.elapsedTimeLabel.element.textContent became "00:05"
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour.html (from rev 228096, trunk/LayoutTests/http/tests/media/modern-media-controls/time-labels-support/long-time.html) (0 => 228097)
--- trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour.html (rev 0)
+++ trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour.html 2018-02-05 16:33:33 UTC (rev 228097)
@@ -0,0 +1,29 @@
+<script src=""
+<script src=""
+<body>
+<video src="" style="width: 320px; height: 240px;" controls autoplay></video>
+<div id="shadow"></div>
+<script type="text/_javascript_">
+
+window.jsTestIsAsync = true;
+
+description("Testing the display of time labels with a video that is 10 minutes or more but less than 1 hour.");
+
+const shadowRoot = document.querySelector("div#shadow").attachShadow({ mode: "open" });
+const media = document.querySelector("video");
+const mediaController = createControls(shadowRoot, media, null);
+
+media.addEventListener("play", () => {
+ media.pause();
+ media.currentTime = 5;
+ shouldBecomeEqualToString("mediaController.controls.timeControl.elapsedTimeLabel.element.textContent", "00:05", () => {
+ debug("");
+ shadowRoot.host.remove();
+ media.remove();
+ finishJSTest();
+ });
+});
+
+</script>
+<script src=""
+</body>
Copied: trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/less-than-10-minutes-expected.txt (from rev 228096, trunk/LayoutTests/http/tests/media/modern-media-controls/time-labels-support/long-time-expected.txt) (0 => 228097)
--- trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/less-than-10-minutes-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/less-than-10-minutes-expected.txt 2018-02-05 16:33:33 UTC (rev 228097)
@@ -0,0 +1,11 @@
+Testing the display of time labels with a video that is less than 10 minutes.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS mediaController.controls.timeControl.elapsedTimeLabel.element.textContent became "0:05"
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/less-than-10-minutes.html (from rev 228096, trunk/LayoutTests/http/tests/media/modern-media-controls/time-labels-support/long-time.html) (0 => 228097)
--- trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/less-than-10-minutes.html (rev 0)
+++ trunk/LayoutTests/http/tests/media/modern-media-controls/time-control/less-than-10-minutes.html 2018-02-05 16:33:33 UTC (rev 228097)
@@ -0,0 +1,29 @@
+<script src=""
+<script src=""
+<body>
+<video src="" style="width: 320px; height: 240px;" controls autoplay></video>
+<div id="shadow"></div>
+<script type="text/_javascript_">
+
+window.jsTestIsAsync = true;
+
+description("Testing the display of time labels with a video that is less than 10 minutes.");
+
+const shadowRoot = document.querySelector("div#shadow").attachShadow({ mode: "open" });
+const media = document.querySelector("video");
+const mediaController = createControls(shadowRoot, media, null);
+
+media.addEventListener("play", () => {
+ media.pause();
+ media.currentTime = 5;
+ shouldBecomeEqualToString("mediaController.controls.timeControl.elapsedTimeLabel.element.textContent", "0:05", () => {
+ debug("");
+ shadowRoot.host.remove();
+ media.remove();
+ finishJSTest();
+ });
+});
+
+</script>
+<script src=""
+</body>
Modified: trunk/LayoutTests/media/modern-media-controls/scrubber-support/scrubber-support-drag.html (228096 => 228097)
--- trunk/LayoutTests/media/modern-media-controls/scrubber-support/scrubber-support-drag.html 2018-02-05 16:30:02 UTC (rev 228096)
+++ trunk/LayoutTests/media/modern-media-controls/scrubber-support/scrubber-support-drag.html 2018-02-05 16:33:33 UTC (rev 228097)
@@ -38,7 +38,7 @@
media.pause();
const dragStartX = bounds.left + bounds.width / 2;
- const dragEndX = bounds.left;
+ const dragEndX = bounds.left - 1;
const centerY = bounds.top + bounds.height / 2;
media.addEventListener("timeupdate", () => {
Modified: trunk/LayoutTests/platform/ios/TestExpectations (228096 => 228097)
--- trunk/LayoutTests/platform/ios/TestExpectations 2018-02-05 16:30:02 UTC (rev 228096)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2018-02-05 16:33:33 UTC (rev 228097)
@@ -3190,52 +3190,6 @@
webkit.org/b/179784 svg/in-html/by-reference.html [ Failure Timeout ]
-# The modern-media-controls tests are disabled due to past flakiness and some major code changes.
-# As a result, a host of tests need to be updated and being turned on selectively here.
-media/modern-media-controls/airplay-button [ Pass ]
-media/modern-media-controls/airplay-placard [ Pass ]
-media/modern-media-controls/audio [ Pass ]
-media/modern-media-controls/background-tint [ Pass ]
-media/modern-media-controls/button [ Pass ]
-media/modern-media-controls/buttons-container [ Pass ]
-media/modern-media-controls/controls-bar [ Pass ]
-media/modern-media-controls/controls-visibility-support [ Pass ]
-media/modern-media-controls/css [ Pass ]
-media/modern-media-controls/forward-button [ Pass ]
-media/modern-media-controls/fullscreen-button [ Pass ]
-media/modern-media-controls/fullscreen-support [ Pass ]
-media/modern-media-controls/icon-service [ Pass ]
-media/modern-media-controls/invalid-placard [ Pass ]
-media/modern-media-controls/ios-inline-media-controls [ Pass ]
-media/modern-media-controls/layout-item [ Pass ]
-media/modern-media-controls/layout-node [ Pass ]
-media/modern-media-controls/localized-strings [ Pass ]
-media/modern-media-controls/media-controller [ Pass ]
-media/modern-media-controls/media-controls [ Pass ]
-media/modern-media-controls/media-documents [ Pass ]
-media/modern-media-controls/mute-button [ Pass ]
-media/modern-media-controls/mute-support [ Pass ]
-media/modern-media-controls/pip-button [ Pass ]
-media/modern-media-controls/pip-placard [ Pass ]
-media/modern-media-controls/pip-support/ipad [ Pass ]
-media/modern-media-controls/placard [ Pass ]
-media/modern-media-controls/placard-support [ Pass ]
-media/modern-media-controls/play-pause-button [ Pass ]
-media/modern-media-controls/playback-support [ Pass ]
-media/modern-media-controls/rewind-button [ Pass ]
-media/modern-media-controls/scheduler [ Pass ]
-media/modern-media-controls/scrubber [ Pass ]
-media/modern-media-controls/scrubber-support [ Pass ]
-media/modern-media-controls/skip-back-button [ Pass ]
-media/modern-media-controls/skip-forward-button [ Pass ]
-media/modern-media-controls/slider [ Pass ]
-media/modern-media-controls/start-support [ Pass ]
-media/modern-media-controls/status-label [ Pass ]
-media/modern-media-controls/status-support [ Pass ]
-media/modern-media-controls/time-control [ Pass ]
-media/modern-media-controls/time-label [ Pass ]
-media/modern-media-controls/time-labels-support [ Pass ]
-
# accessibilityController.role cannot be tested on iOS
media/modern-media-controls/time-label/time-label.html [ Skip ]
media/modern-media-controls/tracks-button [ Pass ]
@@ -3255,8 +3209,12 @@
media/modern-media-controls/pip-support/ipad/pip-support-tap.html [ Skip ]
media/modern-media-controls/placard-support/ipad [ Skip ]
media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html [ Skip ]
+media/modern-media-controls/seek-backward-support [ Skip ]
+media/modern-media-controls/seek-forward-support [ Skip ]
media/modern-media-controls/start-support/start-support-click-to-start.html [ Skip ]
media/modern-media-controls/start-support/start-support-lowPowerMode.html [ Skip ]
+media/modern-media-controls/volume-down-support [ Skip ]
+media/modern-media-controls/volume-up-support [ Skip ]
# There is no focus state for on iOS
media/modern-media-controls/button/button-focus-state.html [ Skip ]
@@ -3276,6 +3234,7 @@
# These tests are designed to work only on macOS
media/modern-media-controls/button/button-click-on-edges.html [ Skip ]
media/modern-media-controls/macos-inline-media-controls [ Skip ]
+media/modern-media-controls/macos-fullscreen-media-controls [ Skip ]
media/modern-media-controls/placard-support/placard-support-pip.html [ Skip ]
media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Skip ]
media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Skip ]
@@ -3287,11 +3246,18 @@
media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html [ Skip ]
media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html [ Skip ]
media/modern-media-controls/media-documents/media-document-video-mac-sizing.html [ Skip ]
+media/modern-media-controls/pip-support [ Skip ]
media/modern-media-controls/playback-support/playback-support-button-click.html [ Skip ]
media/modern-media-controls/scrubber-support/scrubber-support-click.html [ Skip ]
media/modern-media-controls/scrubber-support/scrubber-support-drag.html [ Skip ]
media/modern-media-controls/slider/slider-value.html [ Skip ]
+media/modern-media-controls/text-tracks [ Skip ]
+media/modern-media-controls/tracks-panel [ Skip ]
+media/modern-media-controls/tracks-support [ Skip ]
+media/modern-media-controls/volume-support [ Skip ]
+media/modern-media-controls/pip-support/ipad [ Pass ]
+
webkit.org/b/178127 media/modern-media-controls/media-controller/media-controller-video-with-only-audio.html [ Skip ]
# <rdar://problem/33731086>
Modified: trunk/LayoutTests/platform/mac/TestExpectations (228096 => 228097)
--- trunk/LayoutTests/platform/mac/TestExpectations 2018-02-05 16:30:02 UTC (rev 228096)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2018-02-05 16:33:33 UTC (rev 228097)
@@ -1441,66 +1441,9 @@
webkit.org/b/172469 [ ElCapitan ] imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https.html [ Timeout ]
-# The modern-media-controls tests are disabled due to past flakiness and some major code changes.
-# As a result, a host of tests need to be updated and being turned on selectively here.
-media/modern-media-controls/airplay-button [ Pass ]
-media/modern-media-controls/airplay-placard [ Pass ]
-media/modern-media-controls/airplay-support [ Pass ]
-media/modern-media-controls/audio [ Pass ]
-media/modern-media-controls/background-tint [ Pass ]
-media/modern-media-controls/button [ Pass ]
-media/modern-media-controls/buttons-container [ Pass ]
-media/modern-media-controls/controls-bar [ Pass ]
-media/modern-media-controls/controls-visibility-support [ Pass ]
-media/modern-media-controls/css [ Pass ]
-media/modern-media-controls/forward-button [ Pass ]
-media/modern-media-controls/fullscreen-button [ Pass ]
-media/modern-media-controls/fullscreen-support [ Pass ]
-media/modern-media-controls/icon-service [ Pass ]
-media/modern-media-controls/invalid-placard [ Pass ]
-media/modern-media-controls/layout-item [ Pass ]
-media/modern-media-controls/layout-node [ Pass ]
-media/modern-media-controls/localized-strings [ Pass ]
-media/modern-media-controls/macos-fullscreen-media-controls [ Pass ]
-media/modern-media-controls/macos-inline-media-controls [ Pass ]
-media/modern-media-controls/media-controller [ Pass ]
-media/modern-media-controls/media-controls [ Pass ]
-media/modern-media-controls/media-documents [ Pass ]
-media/modern-media-controls/mute-button [ Pass ]
-media/modern-media-controls/mute-support [ Pass ]
-media/modern-media-controls/pip-button [ Pass ]
-media/modern-media-controls/pip-placard [ Pass ]
-media/modern-media-controls/pip-support [ Pass ]
-media/modern-media-controls/placard [ Pass ]
-media/modern-media-controls/placard-support [ Pass ]
-media/modern-media-controls/play-pause-button [ Pass ]
-media/modern-media-controls/playback-support [ Pass ]
-media/modern-media-controls/rewind-button [ Pass ]
-media/modern-media-controls/scheduler [ Pass ]
-media/modern-media-controls/scrubber [ Pass ]
-media/modern-media-controls/scrubber-support [ Pass ]
-media/modern-media-controls/seek-backward-support [ Pass ]
-media/modern-media-controls/seek-forward-support [ Pass ]
-media/modern-media-controls/skip-back-button [ Pass ]
-media/modern-media-controls/skip-forward-button [ Pass ]
-media/modern-media-controls/slider [ Pass ]
-media/modern-media-controls/start-support [ Pass ]
-media/modern-media-controls/status-label [ Pass ]
-media/modern-media-controls/status-support [ Pass ]
-media/modern-media-controls/text-tracks [ Pass ]
-media/modern-media-controls/time-control [ Pass ]
-media/modern-media-controls/time-label [ Pass ]
-media/modern-media-controls/time-label/ios-time-label.html [ Skip ]
-media/modern-media-controls/time-labels-support [ Pass ]
-media/modern-media-controls/tracks-panel [ Pass ]
-media/modern-media-controls/tracks-support [ Pass ]
-media/modern-media-controls/tracks-button [ Pass ]
-media/modern-media-controls/volume-down-support [ Pass ]
-media/modern-media-controls/volume-support [ Pass ]
-media/modern-media-controls/volume-up-support [ Pass ]
-
# These tests are iOS-specific
media/modern-media-controls/audio/audio-controls-styles.html [ Skip ]
+media/modern-media-controls/ios-inline-media-controls [ Skip ]
media/modern-media-controls/placard-support/ipad [ Skip ]
media/modern-media-controls/media-controller/ios [ Skip ]
media/modern-media-controls/media-documents/ipad [ Skip ]
