Title: [228185] trunk
- Revision
- 228185
- Author
- grao...@webkit.org
- Date
- 2018-02-06 11:36:40 -0800 (Tue, 06 Feb 2018)
Log Message
[Modern Media Controls] Test at media/modern-media-controls/tracks-panel/tracks-panel-controls-bar-remains-visible-after-clicking-over-it.html fails
https://bugs.webkit.org/show_bug.cgi?id=182425
Reviewed by Dean Jackson.
Source/WebCore:
This test failed because the controls bar would not hit test at the moment we synthesized a mousemove over the controls bar as the first step towards
synthesizing a click on the controls bar to dismiss the tracks panel. Indeed, it would have "pointer-events" set to "none" until the tracks panel was
dismissed, which would only happen after the click event had been propagated. All we need to do is to ensure that none of the controls within the controls
bar get activated as a result of clicking over them when the tracks panel is visible, so we instead set "pointer-events" to "none" on all children of a
controls bar rather than the controls bar itself, which can thus still hit test.
* Modules/modern-media-controls/controls/media-controls.css:
(.media-controls.shows-tracks-panel > .controls-bar > *,):
(.media-controls.shows-tracks-panel > .controls-bar,): Deleted.
LayoutTests:
Turn the test back on now that it works.
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (228184 => 228185)
--- trunk/LayoutTests/ChangeLog 2018-02-06 19:20:23 UTC (rev 228184)
+++ trunk/LayoutTests/ChangeLog 2018-02-06 19:36:40 UTC (rev 228185)
@@ -1,5 +1,16 @@
2018-02-06 Antoine Quint <grao...@apple.com>
+ [Modern Media Controls] Test at media/modern-media-controls/tracks-panel/tracks-panel-controls-bar-remains-visible-after-clicking-over-it.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=182425
+
+ Reviewed by Dean Jackson.
+
+ Turn the test back on now that it works.
+
+ * platform/mac/TestExpectations:
+
+2018-02-06 Antoine Quint <grao...@apple.com>
+
Layout Test media/modern-media-controls/slider/slider-value.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=182515
Modified: trunk/LayoutTests/platform/mac/TestExpectations (228184 => 228185)
--- trunk/LayoutTests/platform/mac/TestExpectations 2018-02-06 19:20:23 UTC (rev 228184)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2018-02-06 19:36:40 UTC (rev 228185)
@@ -1462,7 +1462,6 @@
webkit.org/b/178126 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Skip ]
webkit.org/b/178127 media/modern-media-controls/media-controller/media-controller-video-with-only-audio.html [ Skip ]
-webkit.org/b/182425 media/modern-media-controls/tracks-panel/tracks-panel-controls-bar-remains-visible-after-clicking-over-it.html [ Failure ]
# This test relies on the control overlay not being visible in the top left. But the test now fails on Mac because
# the image is dumped after the video is loaded and the control overlay is displayed. It seems the test still works
Modified: trunk/Source/WebCore/ChangeLog (228184 => 228185)
--- trunk/Source/WebCore/ChangeLog 2018-02-06 19:20:23 UTC (rev 228184)
+++ trunk/Source/WebCore/ChangeLog 2018-02-06 19:36:40 UTC (rev 228185)
@@ -1,3 +1,20 @@
+2018-02-06 Antoine Quint <grao...@apple.com>
+
+ [Modern Media Controls] Test at media/modern-media-controls/tracks-panel/tracks-panel-controls-bar-remains-visible-after-clicking-over-it.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=182425
+
+ Reviewed by Dean Jackson.
+
+ This test failed because the controls bar would not hit test at the moment we synthesized a mousemove over the controls bar as the first step towards
+ synthesizing a click on the controls bar to dismiss the tracks panel. Indeed, it would have "pointer-events" set to "none" until the tracks panel was
+ dismissed, which would only happen after the click event had been propagated. All we need to do is to ensure that none of the controls within the controls
+ bar get activated as a result of clicking over them when the tracks panel is visible, so we instead set "pointer-events" to "none" on all children of a
+ controls bar rather than the controls bar itself, which can thus still hit test.
+
+ * Modules/modern-media-controls/controls/media-controls.css:
+ (.media-controls.shows-tracks-panel > .controls-bar > *,):
+ (.media-controls.shows-tracks-panel > .controls-bar,): Deleted.
+
2018-02-06 Chris Dumez <cdu...@apple.com>
Service workers registrations are saved to disk before the install / activation succeeds
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css (228184 => 228185)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css 2018-02-06 19:20:23 UTC (rev 228184)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css 2018-02-06 19:36:40 UTC (rev 228185)
@@ -97,7 +97,7 @@
transition: opacity 0.1s linear;
}
-.media-controls.shows-tracks-panel > .controls-bar,
+.media-controls.shows-tracks-panel > .controls-bar > *,
.media-controls.shows-tracks-panel > button {
pointer-events: none;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
