Title: [228296] trunk/Source/WebInspectorUI
Revision
228296
Author
nvasil...@apple.com
Date
2018-02-08 15:18:28 -0800 (Thu, 08 Feb 2018)

Log Message

Web Inspector: Styles: Typing value and quickly moving focus away may display outdated value in UI
https://bugs.webkit.org/show_bug.cgi?id=182588
<rdar://problem/37332161>

Reviewed by Matt Baker.

CSSProperty models were updated with a 250ms delay. Quickly adding a blank property after modifying
an existing property could result in outdated values being shown.

This patch removes the 250ms delay.

* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidChange):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (228295 => 228296)


--- trunk/Source/WebInspectorUI/ChangeLog	2018-02-08 23:03:20 UTC (rev 228295)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-02-08 23:18:28 UTC (rev 228296)
@@ -1,3 +1,19 @@
+2018-02-08  Nikita Vasilyev  <nvasil...@apple.com>
+
+        Web Inspector: Styles: Typing value and quickly moving focus away may display outdated value in UI
+        https://bugs.webkit.org/show_bug.cgi?id=182588
+        <rdar://problem/37332161>
+
+        Reviewed by Matt Baker.
+
+        CSSProperty models were updated with a 250ms delay. Quickly adding a blank property after modifying
+        an existing property could result in outdated values being shown.
+
+        This patch removes the 250ms delay.
+
+        * UserInterface/Views/SpreadsheetStyleProperty.js:
+        (WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidChange):
+
 2018-02-07  Matt Baker  <mattba...@apple.com>
 
         Web Inspector: replace isAncestor with Node.contains() in LegacyTabBar

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js (228295 => 228296)


--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js	2018-02-08 23:03:20 UTC (rev 228295)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js	2018-02-08 23:18:28 UTC (rev 228296)
@@ -247,9 +247,9 @@
     spreadsheetTextFieldDidChange(textField)
     {
         if (textField === this._valueTextField)
-            this.debounce(WI.SpreadsheetStyleProperty.CommitCoalesceDelay)._handleValueChange();
+            this._handleValueChange();
         else if (textField === this._nameTextField)
-            this.debounce(WI.SpreadsheetStyleProperty.CommitCoalesceDelay)._handleNameChange();
+            this._handleNameChange();
     }
 
     spreadsheetTextFieldDidCommit(textField, {direction})
@@ -666,5 +666,3 @@
 };
 
 WI.SpreadsheetStyleProperty.StyleClassName = "property";
-
-WI.SpreadsheetStyleProperty.CommitCoalesceDelay = 250;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to