Title: [229687] trunk/Websites/perf.webkit.org
- Revision
- 229687
- Author
- aakash_j...@apple.com
- Date
- 2018-03-16 16:48:37 -0700 (Fri, 16 Mar 2018)
Log Message
BuildbotBuildEntry creates an incorrect url for pending builds
https://bugs.webkit.org/show_bug.cgi?id=183670
Reviewed by Ryosuke Niwa.
* tools/js/buildbot-syncer.js:
(BuildbotBuildEntry.prototype.initialize): Fetch buildrequestid from Buildbot.
(BuildbotBuildEntry.prototype.url): Construct url for pending build using buildrequestid from Buildbot.
* unit-tests/buildbot-syncer-tests.js: Updated unit-test.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (229686 => 229687)
--- trunk/Websites/perf.webkit.org/ChangeLog 2018-03-16 23:43:41 UTC (rev 229686)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2018-03-16 23:48:37 UTC (rev 229687)
@@ -1,3 +1,15 @@
+2018-03-15 Aakash Jain <aakash_j...@apple.com>
+
+ BuildbotBuildEntry creates an incorrect url for pending builds
+ https://bugs.webkit.org/show_bug.cgi?id=183670
+
+ Reviewed by Ryosuke Niwa.
+
+ * tools/js/buildbot-syncer.js:
+ (BuildbotBuildEntry.prototype.initialize): Fetch buildrequestid from Buildbot.
+ (BuildbotBuildEntry.prototype.url): Construct url for pending build using buildrequestid from Buildbot.
+ * unit-tests/buildbot-syncer-tests.js: Updated unit-test.
+
2018-03-14 Aakash Jain <aakash_j...@apple.com>
Add support for boolean properties in BuildbotSyncer while submitting build request to Buildbot 0.9 server
Modified: trunk/Websites/perf.webkit.org/tools/js/buildbot-syncer.js (229686 => 229687)
--- trunk/Websites/perf.webkit.org/tools/js/buildbot-syncer.js 2018-03-16 23:43:41 UTC (rev 229686)
+++ trunk/Websites/perf.webkit.org/tools/js/buildbot-syncer.js 2018-03-16 23:48:37 UTC (rev 229687)
@@ -15,6 +15,7 @@
assert.equal(syncer.builderID(), rawData['builderid']);
this._syncer = syncer;
+ this._buildbotBuildRequestId = rawData['buildrequestid']
this._hasFinished = rawData['complete'];
this._isPending = 'claimed' in rawData && !rawData['claimed'];
this._isInProgress = !this._isPending && !this._hasFinished;
@@ -32,7 +33,7 @@
isPending() { return this._isPending; }
isInProgress() { return this._isInProgress; }
hasFinished() { return this._hasFinished; }
- url() { return this.isPending() ? this._syncer.urlForPendingBuild(this._buildRequestId) : this._syncer.urlForBuildNumber(this._buildNumber); }
+ url() { return this.isPending() ? this._syncer.urlForPendingBuild(this._buildbotBuildRequestId) : this._syncer.urlForBuildNumber(this._buildNumber); }
buildRequestStatusIfUpdateIsNeeded(request)
{
Modified: trunk/Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js (229686 => 229687)
--- trunk/Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js 2018-03-16 23:43:41 UTC (rev 229686)
+++ trunk/Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js 2018-03-16 23:48:37 UTC (rev 229687)
@@ -1305,7 +1305,7 @@
assert.ok(entry.isPending());
assert.ok(!entry.isInProgress());
assert.ok(!entry.hasFinished());
- assert.equal(entry.url(), 'http://build.webkit.org/#/buildrequests/16733');
+ assert.equal(entry.url(), 'http://build.webkit.org/#/buildrequests/17');
});
it('should create BuildbotBuildEntry for in-progress build', () => {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
