Title: [230001] trunk/Source/WebInspectorUI
- Revision
- 230001
- Author
- nvasil...@apple.com
- Date
- 2018-03-27 12:30:59 -0700 (Tue, 27 Mar 2018)
Log Message
Web Inspector: Command-Shift-left/right arrow keys should not switch tabs when focused on color picker text fields
https://bugs.webkit.org/show_bug.cgi?id=184028
Reviewed by Timothy Hatcher.
* UserInterface/Views/EditingSupport.js:
(WI.isEventTargetAnEditableField):
Detect <input type="number"> as an editable text field.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (230000 => 230001)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-03-27 19:19:46 UTC (rev 230000)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-03-27 19:30:59 UTC (rev 230001)
@@ -1,3 +1,14 @@
+2018-03-27 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: Command-Shift-left/right arrow keys should not switch tabs when focused on color picker text fields
+ https://bugs.webkit.org/show_bug.cgi?id=184028
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/EditingSupport.js:
+ (WI.isEventTargetAnEditableField):
+ Detect <input type="number"> as an editable text field.
+
2018-03-23 Nikita Vasilyev <nvasil...@apple.com>
Web Inspector: Styles: don't show checkboxes for invalid properties
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/EditingSupport.js (230000 => 230001)
--- trunk/Source/WebInspectorUI/UserInterface/Views/EditingSupport.js 2018-03-27 19:19:46 UTC (rev 230000)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/EditingSupport.js 2018-03-27 19:30:59 UTC (rev 230001)
@@ -57,11 +57,11 @@
WI.isEventTargetAnEditableField = function(event)
{
- var textInputTypes = {"text": true, "search": true, "tel": true, "url": true, "email": true, "password": true};
+ let textInputTypes = new Set(["text", "search", "number", "tel", "url", "email", "password"]);
if (event.target instanceof HTMLInputElement)
- return event.target.type in textInputTypes;
+ return textInputTypes.has(event.target.type);
- var codeMirrorEditorElement = event.target.enclosingNodeOrSelfWithClass("CodeMirror");
+ let codeMirrorEditorElement = event.target.enclosingNodeOrSelfWithClass("CodeMirror");
if (codeMirrorEditorElement && codeMirrorEditorElement.CodeMirror)
return !codeMirrorEditorElement.CodeMirror.getOption("readOnly");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
