Title: [230553] trunk/Source/bmalloc
- Revision
- 230553
- Author
- sbar...@apple.com
- Date
- 2018-04-11 19:44:06 -0700 (Wed, 11 Apr 2018)
Log Message
raise partial scavenge interval on x86-64
https://bugs.webkit.org/show_bug.cgi?id=184521
Rubber-stamped by Filip Pizlo.
This patch is an attempt to recover the 1-3% JetStream regression
my initial partial scavenging patch introduced on some Macs.
* bmalloc/Scavenger.cpp:
(bmalloc::Scavenger::threadRunLoop):
Modified Paths
Diff
Modified: trunk/Source/bmalloc/ChangeLog (230552 => 230553)
--- trunk/Source/bmalloc/ChangeLog 2018-04-12 01:09:15 UTC (rev 230552)
+++ trunk/Source/bmalloc/ChangeLog 2018-04-12 02:44:06 UTC (rev 230553)
@@ -1,3 +1,16 @@
+2018-04-11 Saam Barati <sbar...@apple.com>
+
+ raise partial scavenge interval on x86-64
+ https://bugs.webkit.org/show_bug.cgi?id=184521
+
+ Rubber-stamped by Filip Pizlo.
+
+ This patch is an attempt to recover the 1-3% JetStream regression
+ my initial partial scavenging patch introduced on some Macs.
+
+ * bmalloc/Scavenger.cpp:
+ (bmalloc::Scavenger::threadRunLoop):
+
2018-04-10 Saam Barati <sbar...@apple.com>
IsoHeapImpl::scavenge* needs to grab the lock
Modified: trunk/Source/bmalloc/bmalloc/Scavenger.cpp (230552 => 230553)
--- trunk/Source/bmalloc/bmalloc/Scavenger.cpp 2018-04-12 01:09:15 UTC (rev 230552)
+++ trunk/Source/bmalloc/bmalloc/Scavenger.cpp 2018-04-12 02:44:06 UTC (rev 230553)
@@ -407,7 +407,12 @@
return ScavengeMode::Full;
}
- if (timeSinceLastScavenge < std::chrono::milliseconds(8000)) {
+#if BCPU(X86_64)
+ auto partialScavengeInterval = std::chrono::milliseconds(20000);
+#else
+ auto partialScavengeInterval = std::chrono::milliseconds(8000);
+#endif
+ if (timeSinceLastScavenge < partialScavengeInterval) {
// Rate limit partial scavenges.
return ScavengeMode::None;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
