Title: [231323] trunk/Tools
- Revision
- 231323
- Author
- commit-qu...@webkit.org
- Date
- 2018-05-03 13:27:43 -0700 (Thu, 03 May 2018)
Log Message
test262/Runner.pm: minor fixes
https://bugs.webkit.org/show_bug.cgi?id=185250
Patch by Valerie R Young <vale...@bocoup.com> on 2018-05-03
Reviewed by Michael Saboff.
Add comments, change output and fix bug: unintended interpolation
of filename when running jsc.
* Scripts/test262/Runner.pm:
(processCLI):
(main):
(runTest):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (231322 => 231323)
--- trunk/Tools/ChangeLog 2018-05-03 20:16:14 UTC (rev 231322)
+++ trunk/Tools/ChangeLog 2018-05-03 20:27:43 UTC (rev 231323)
@@ -1,3 +1,18 @@
+2018-05-03 Valerie R Young <vale...@bocoup.com>
+
+ test262/Runner.pm: minor fixes
+ https://bugs.webkit.org/show_bug.cgi?id=185250
+
+ Reviewed by Michael Saboff.
+
+ Add comments, change output and fix bug: unintended interpolation
+ of filename when running jsc.
+
+ * Scripts/test262/Runner.pm:
+ (processCLI):
+ (main):
+ (runTest):
+
2018-05-03 Chris Dumez <cdu...@apple.com>
Load hangs if the WebProcess fails to launch
Modified: trunk/Tools/Scripts/test262/Runner.pm (231322 => 231323)
--- trunk/Tools/Scripts/test262/Runner.pm 2018-05-03 20:16:14 UTC (rev 231322)
+++ trunk/Tools/Scripts/test262/Runner.pm 2018-05-03 20:27:43 UTC (rev 231323)
@@ -61,9 +61,8 @@
use Parallel::ForkManager;
use Getopt::Long qw(GetOptions);
use Pod::Usage;
-use Term::ANSIColor;
-# Commandline args
+# Commandline settings
my $max_process;
my @cliTestDirs;
my $verbose;
@@ -79,7 +78,11 @@
my $failingOnly;
my $latestImport;
my $runningAllTests;
+
+processCLI();
+
my @results;
+my @files;
my $expectationsFile = abs_path("$Bin/expectations.yaml");
my $configFile = abs_path("$Bin/config.yaml");
@@ -87,8 +90,6 @@
my $summaryTxtFile = abs_path("$Bin/results-summary.txt");
my $summaryFile = abs_path("$Bin/results-summary.yaml");
-processCLI();
-
my $tempdir = tempdir();
my @default_harnesses = (
@@ -98,8 +99,6 @@
"$Bin/agent.js"
);
-my @files;
-
my ($deffh, $deffile) = getTempFile();
print $deffh getHarness(<@default_harnesses>);
@@ -156,8 +155,6 @@
}
} else {
$JSC = getBuildPath($debug);
-
- print("Using the following jsc path: $JSC\n");
}
if ($latestImport) {
@@ -219,6 +216,8 @@
}
sub main {
+
+ # If not commandline test path supplied, use the root directory of all tests.
push(@cliTestDirs, 'test') if not @cliTestDirs;
if ($latestImport) {
@@ -242,7 +241,7 @@
# If we are processing many files, fork process
- if (scalar @files > $max_process * 10) {
+ if (scalar @files > $max_process * 5) {
# Make temporary files to record results
my @resultsfhs;
@@ -578,7 +577,7 @@
my $defaultHarness = '';
$defaultHarness = $deffile if $scenario ne 'raw';
- my $result = qx/$JSC $args $defaultHarness $includesfile $prefixFile$filename/;
+ my $result = qx/$JSC $args $defaultHarness $includesfile '$prefixFile$filename'/;
chomp $result;
@@ -857,7 +856,7 @@
=item B<--save, -s>
-Overwrites the test262-expectations.yaml and test262-results.yaml file with the current list of test262 files and test results.
+Overwrites the test262-expectations.yaml file with the current list of test262 files and test results.
=item B<--ignore-expectations, -x>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
