Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/config.json (233228 => 233229)
--- trunk/Tools/BuildSlaveSupport/ews-build/config.json 2018-06-27 00:10:23 UTC (rev 233228)
+++ trunk/Tools/BuildSlaveSupport/ews-build/config.json 2018-06-27 00:16:48 UTC (rev 233229)
@@ -265,6 +265,12 @@
"factory": "WebkitpyFactory",
"platform": "*",
"workernames": ["webkit-misc"]
+ },
+ {
+ "name": "WebKitPerl-Tests-EWS",
+ "factory": "WebKitPerlFactory",
+ "platform": "*",
+ "workernames": ["webkit-misc"]
}
],
"schedulers": [
@@ -274,7 +280,7 @@
"port": 5555,
"builderNames": ["Style-EWS", "JSC-tests-EWS", "macOS-Sierra-Release-WK1-EWS", "GTK-Webkit2-EWS", "macOS-Sierra-Release-WK2-EWS",
"macOS-High-Sierra-Release-32bit-WK2-EWS", "WPE-EWS", "Windows-EWS", "iOS-11-EWS", "WinCairo-EWS", "iOS-11-Simulator-EWS",
- "Webkitpy-tests-EWS", "macOS-Sierra-Debug-WK1-EWS", "Bindings-tests-EWS"]
+ "Webkitpy-tests-EWS", "WebKitPerl-Tests-EWS", "macOS-Sierra-Debug-WK1-EWS", "Bindings-tests-EWS"]
}
]
}
Modified: trunk/Tools/BuildSlaveSupport/ews-build/factories.py (233228 => 233229)
--- trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2018-06-27 00:10:23 UTC (rev 233228)
+++ trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2018-06-27 00:16:48 UTC (rev 233229)
@@ -45,6 +45,12 @@
self.addStep(RunBindingsTests())
+class WebKitPerlFactory(Factory):
+ def __init__(self, platform, configuration=None, architectures=None, additionalArguments=None, **kwargs):
+ Factory.__init__(self, platform, configuration, architectures, False, additionalArguments)
+ self.addStep(RunWebKitPerlTests())
+
+
class GTKFactory(Factory):
pass
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (233228 => 233229)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2018-06-27 00:10:23 UTC (rev 233228)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2018-06-27 00:16:48 UTC (rev 233229)
@@ -79,3 +79,11 @@
descriptionDone = ['bindings-tests']
flunkOnFailure = True
command = ['Tools/Scripts/run-bindings-tests']
+
+
+class RunWebKitPerlTests(shell.ShellCommand):
+ name = 'webkitperl-tests'
+ description = ['webkitperl-tests running']
+ descriptionDone = ['webkitperl-tests']
+ flunkOnFailure = True
+ command = ['Tools/Scripts/test-webkitperl']
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (233228 => 233229)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2018-06-27 00:10:23 UTC (rev 233228)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2018-06-27 00:16:48 UTC (rev 233229)
@@ -260,5 +260,40 @@
return self.runStep()
+class TestunWebKitPerlTests(BuildStepMixinAdditions, unittest.TestCase):
+ def setUp(self):
+ self.longMessage = True
+ return self.setUpBuildStep()
+
+ def tearDown(self):
+ return self.tearDownBuildStep()
+
+ def test_success(self):
+ self.setupStep(RunWebKitPerlTests())
+ self.expectRemoteCommands(
+ ExpectShell(workdir='wkdir',
+ command=['Tools/Scripts/test-webkitperl'],
+ )
+ + 0,
+ )
+ self.expectOutcome(result=SUCCESS, state_string='webkitperl-tests')
+ return self.runStep()
+
+ def test_failure(self):
+ self.setupStep(RunWebKitPerlTests())
+ self.expectRemoteCommands(
+ ExpectShell(workdir='wkdir',
+ command=['Tools/Scripts/test-webkitperl'],
+ )
+ + ExpectShell.log('stdio', stdout='''Failed tests: 1-3, 5-7, 9, 11-13
+Files=40, Tests=630, 4 wallclock secs ( 0.16 usr 0.09 sys + 2.78 cusr 0.64 csys = 3.67 CPU)
+Result: FAIL
+Failed 1/40 test programs. 10/630 subtests failed.''')
+ + 2,
+ )
+ self.expectOutcome(result=FAILURE, state_string='webkitperl-tests (failure)')
+ return self.runStep()
+
+
if __name__ == '__main__':
unittest.main()
Modified: trunk/Tools/ChangeLog (233228 => 233229)
--- trunk/Tools/ChangeLog 2018-06-27 00:10:23 UTC (rev 233228)
+++ trunk/Tools/ChangeLog 2018-06-27 00:16:48 UTC (rev 233229)
@@ -1,5 +1,17 @@
2018-06-26 Aakash Jain <aakash_j...@apple.com>
+ [ews-build] Add support for WebKitPerl-Tests-EWS
+ https://bugs.webkit.org/show_bug.cgi?id=187023
+
+ Reviewed by Lucas Forschler.
+
+ * BuildSlaveSupport/ews-build/config.json: Added WebKitPerl-tests-EWS.
+ * BuildSlaveSupport/ews-build/factories.py: Added WebKitPerlFactory.
+ * BuildSlaveSupport/ews-build/steps.py: Added build step RunWebKitPerlTests.
+ * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
+
+2018-06-26 Aakash Jain <aakash_j...@apple.com>
+
[build.webkit.org] Rename badly named variable kls to schedulerType
https://bugs.webkit.org/show_bug.cgi?id=186926
