Title: [233684] trunk/Source/WebCore
- Revision
- 233684
- Author
- commit-qu...@webkit.org
- Date
- 2018-07-10 09:33:04 -0700 (Tue, 10 Jul 2018)
Log Message
[GTK][WPE] The LibWebRTCProvider object in RealtimeMediaSourceCenterLibWebRTC is not needed anymore
https://bugs.webkit.org/show_bug.cgi?id=187513
Patch by Alejandro G. Castro <a...@igalia.com> on 2018-07-10
Reviewed by Youenn Fablet.
We used the factory of the LibWebRTCProvider in
RealtimeMediaSourceCenterLibWebRTC as a singleton to make sure the
devices were correctly listed and used, we needed this when using
libwebrtc media devices management. We are now using GStreamer to handle
the media devices so this is not needed anymore.
No new tests, this change removed unused code.
* platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.cpp:
(WebCore::RealtimeMediaSourceCenterLibWebRTC::RealtimeMediaSourceCenterLibWebRTC):
* platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (233683 => 233684)
--- trunk/Source/WebCore/ChangeLog 2018-07-10 16:24:40 UTC (rev 233683)
+++ trunk/Source/WebCore/ChangeLog 2018-07-10 16:33:04 UTC (rev 233684)
@@ -1,3 +1,22 @@
+2018-07-10 Alejandro G. Castro <a...@igalia.com>
+
+ [GTK][WPE] The LibWebRTCProvider object in RealtimeMediaSourceCenterLibWebRTC is not needed anymore
+ https://bugs.webkit.org/show_bug.cgi?id=187513
+
+ Reviewed by Youenn Fablet.
+
+ We used the factory of the LibWebRTCProvider in
+ RealtimeMediaSourceCenterLibWebRTC as a singleton to make sure the
+ devices were correctly listed and used, we needed this when using
+ libwebrtc media devices management. We are now using GStreamer to handle
+ the media devices so this is not needed anymore.
+
+ No new tests, this change removed unused code.
+
+ * platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.cpp:
+ (WebCore::RealtimeMediaSourceCenterLibWebRTC::RealtimeMediaSourceCenterLibWebRTC):
+ * platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.h:
+
2018-07-10 Zalan Bujtas <za...@apple.com>
Rollout r233530: Candidate for Speedometer regression.
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.cpp (233683 => 233684)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.cpp 2018-07-10 16:24:40 UTC (rev 233683)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.cpp 2018-07-10 16:33:04 UTC (rev 233684)
@@ -50,7 +50,6 @@
}
RealtimeMediaSourceCenterLibWebRTC::RealtimeMediaSourceCenterLibWebRTC()
- : m_libWebRTCProvider(LibWebRTCProvider::create())
{
}
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.h (233683 => 233684)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.h 2018-07-10 16:24:40 UTC (rev 233683)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/RealtimeMediaSourceCenterLibWebRTC.h 2018-07-10 16:33:04 UTC (rev 233684)
@@ -38,8 +38,6 @@
public:
WEBCORE_EXPORT static RealtimeMediaSourceCenterLibWebRTC& singleton();
- webrtc::PeerConnectionFactoryInterface* factory() { return m_libWebRTCProvider->factory(); }
-
static RealtimeMediaSource::VideoCaptureFactory& videoCaptureSourceFactory();
static RealtimeMediaSource::AudioCaptureFactory& audioCaptureSourceFactory();
@@ -59,7 +57,6 @@
CaptureDeviceManager& displayCaptureDeviceManager() final;
RealtimeMediaSource::AudioCaptureFactory* m_audioFactoryOverride { nullptr };
- UniqueRef<LibWebRTCProvider> m_libWebRTCProvider;
};
} // namespace WebCore
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
