Title: [233878] trunk/Tools
- Revision
- 233878
- Author
- commit-qu...@webkit.org
- Date
- 2018-07-16 19:17:38 -0700 (Mon, 16 Jul 2018)
Log Message
Fix API Test failures introduced by r233865
https://bugs.webkit.org/show_bug.cgi?id=187720
Unreviewed APITest fix after r233865.
Fullscreen can now only be initiated from a window that is on screen.
Patch by Jeremy Jones <jere...@apple.com> on 2018-07-16
* TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (233877 => 233878)
--- trunk/Tools/ChangeLog 2018-07-17 02:03:33 UTC (rev 233877)
+++ trunk/Tools/ChangeLog 2018-07-17 02:17:38 UTC (rev 233878)
@@ -1,3 +1,17 @@
+2018-07-16 Jeremy Jones <jere...@apple.com>
+
+ Fix API Test failures introduced by r233865
+ https://bugs.webkit.org/show_bug.cgi?id=187720
+
+ Unreviewed APITest fix after r233865.
+
+ Fullscreen can now only be initiated from a window that is on screen.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
+ (TestWebKitAPI::TEST):
+ * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
+ (TestWebKitAPI::TEST):
+
2018-07-11 Dean Jackson <d...@apple.com>
Allow removal of white backgrounds
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm (233877 => 233878)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm 2018-07-17 02:03:33 UTC (rev 233877)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm 2018-07-17 02:17:38 UTC (rev 233878)
@@ -94,6 +94,7 @@
RetainPtr<NSWindow> window = adoptNS([[NSWindow alloc] initWithContentRect:[webView frame] styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:NO]);
[[window contentView] addSubview:webView.get()];
+ [window makeKeyAndOrderFront:nil];
NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"FullscreenDelegate" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
[webView loadRequest:request];
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm (233877 => 233878)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm 2018-07-17 02:03:33 UTC (rev 233877)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm 2018-07-17 02:17:38 UTC (rev 233878)
@@ -65,6 +65,7 @@
RetainPtr<NSWindow> window = adoptNS([[NSWindow alloc] initWithContentRect:[webView frame] styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:NO]);
[[window contentView] addSubview:webView.get()];
+ [window makeKeyAndOrderFront:nil];
NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"FullscreenTopContentInset" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
[webView loadRequest:request];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
