Title: [233989] trunk/Source/WebInspectorUI
- Revision
- 233989
- Author
- nvasil...@apple.com
- Date
- 2018-07-19 10:37:17 -0700 (Thu, 19 Jul 2018)
Log Message
Web Inspector: Dark Mode: poor contrast for Search Tab's "the page's content has changed" message
https://bugs.webkit.org/show_bug.cgi?id=187792
Reviewed by Brian Burg.
* UserInterface/Views/DarkMode.css:
(@media (prefers-dark-interface)):
(:root):
Make the background color slightly more yellow and less red. This slightly dicreases the contrast
but makes the text look less like an error.
* UserInterface/Views/SearchSidebarPanel.css:
(@media (prefers-dark-interface)):
(.sidebar > .panel.navigation.search.changed > .banner):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (233988 => 233989)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-07-19 17:07:57 UTC (rev 233988)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-07-19 17:37:17 UTC (rev 233989)
@@ -1,3 +1,20 @@
+2018-07-19 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: Dark Mode: poor contrast for Search Tab's "the page's content has changed" message
+ https://bugs.webkit.org/show_bug.cgi?id=187792
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/DarkMode.css:
+ (@media (prefers-dark-interface)):
+ (:root):
+ Make the background color slightly more yellow and less red. This slightly dicreases the contrast
+ but makes the text look less like an error.
+
+ * UserInterface/Views/SearchSidebarPanel.css:
+ (@media (prefers-dark-interface)):
+ (.sidebar > .panel.navigation.search.changed > .banner):
+
2018-07-18 Matt Baker <mattba...@apple.com>
Web Inspector: REGRESSION(r232591): CodeMirrorEditor should not use a RegExp lineSeparator option
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DarkMode.css (233988 => 233989)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DarkMode.css 2018-07-19 17:07:57 UTC (rev 233988)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DarkMode.css 2018-07-19 17:37:17 UTC (rev 233989)
@@ -93,7 +93,7 @@
--green-highlight-background-color: hsl(120, 15%, 28%);
--green-highlight-text-color: hsl(80, 75%, 80%);
- --yellow-highlight-background-color: hsl(3, 20%, 26%);
+ --yellow-highlight-background-color: hsl(13, 20%, 26%);
--yellow-highlight-text-color: hsl(50, 96%, 87%);
--value-changed-highlight: var(--green-highlight-background-color);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.css (233988 => 233989)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.css 2018-07-19 17:07:57 UTC (rev 233988)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.css 2018-07-19 17:37:17 UTC (rev 233989)
@@ -78,3 +78,10 @@
.sidebar > .panel.navigation.search.changed > :matches(.content, .message-text-view) {
top: calc(var(--navigation-bar-height) + 40px - 1px);
}
+
+@media (prefers-dark-interface) {
+ .sidebar > .panel.navigation.search.changed > .banner {
+ background-color: var(--yellow-highlight-background-color);
+ color: var(--yellow-highlight-text-color);
+ }
+}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
