Title: [234007] trunk/Source/WebCore
- Revision
- 234007
- Author
- grao...@webkit.org
- Date
- 2018-07-19 14:55:41 -0700 (Thu, 19 Jul 2018)
Log Message
Ensure DocumentTimeline is kept alive until the VM::whenIdle callback is called
https://bugs.webkit.org/show_bug.cgi?id=187692
Reviewed by Ryosuke Niwa.
Ensure we keep the DocumentTimeline alive until the VM::whenIdle callback is called.
* animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::currentTime):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (234006 => 234007)
--- trunk/Source/WebCore/ChangeLog 2018-07-19 21:54:48 UTC (rev 234006)
+++ trunk/Source/WebCore/ChangeLog 2018-07-19 21:55:41 UTC (rev 234007)
@@ -1,3 +1,15 @@
+2018-07-19 Antoine Quint <grao...@apple.com>
+
+ Ensure DocumentTimeline is kept alive until the VM::whenIdle callback is called
+ https://bugs.webkit.org/show_bug.cgi?id=187692
+
+ Reviewed by Ryosuke Niwa.
+
+ Ensure we keep the DocumentTimeline alive until the VM::whenIdle callback is called.
+
+ * animation/DocumentTimeline.cpp:
+ (WebCore::DocumentTimeline::currentTime):
+
2018-07-18 Simon Fraser <simon.fra...@apple.com>
Setting foreground color when editing should take color-filter into account, and report the correct foreground color for collapsed selections
Modified: trunk/Source/WebCore/animation/DocumentTimeline.cpp (234006 => 234007)
--- trunk/Source/WebCore/animation/DocumentTimeline.cpp 2018-07-19 21:54:48 UTC (rev 234006)
+++ trunk/Source/WebCore/animation/DocumentTimeline.cpp 2018-07-19 21:55:41 UTC (rev 234007)
@@ -174,7 +174,7 @@
// fire syncronously if no JS is running.
scheduleInvalidationTaskIfNeeded();
m_waitingOnVMIdle = true;
- m_document->vm().whenIdle([this]() {
+ m_document->vm().whenIdle([this, protectedThis = makeRefPtr(this)]() {
m_waitingOnVMIdle = false;
maybeClearCachedCurrentTime();
});
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
