Title: [235238] trunk/Source/_javascript_Core
- Revision
- 235238
- Author
- msab...@apple.com
- Date
- 2018-08-23 12:57:44 -0700 (Thu, 23 Aug 2018)
Log Message
YARR: Need to JIT compile a RegExp before using containsNestedSubpatterns flag
https://bugs.webkit.org/show_bug.cgi?id=188895
Reviewed by Mark Lam.
Found while working on another change. This will allow processing of nested
parenthesis that require saved ParenContext structures.
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (235237 => 235238)
--- trunk/Source/_javascript_Core/ChangeLog 2018-08-23 19:52:16 UTC (rev 235237)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-08-23 19:57:44 UTC (rev 235238)
@@ -1,3 +1,16 @@
+2018-08-23 Michael Saboff <msab...@apple.com>
+
+ YARR: Need to JIT compile a RegExp before using containsNestedSubpatterns flag
+ https://bugs.webkit.org/show_bug.cgi?id=188895
+
+ Reviewed by Mark Lam.
+
+ Found while working on another change. This will allow processing of nested
+ parenthesis that require saved ParenContext structures.
+
+ * yarr/YarrJIT.cpp:
+ (JSC::Yarr::YarrGenerator::compile):
+
2018-08-22 Michael Saboff <msab...@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=188859
Modified: trunk/Source/_javascript_Core/yarr/YarrJIT.cpp (235237 => 235238)
--- trunk/Source/_javascript_Core/yarr/YarrJIT.cpp 2018-08-23 19:52:16 UTC (rev 235237)
+++ trunk/Source/_javascript_Core/yarr/YarrJIT.cpp 2018-08-23 19:57:44 UTC (rev 235238)
@@ -3545,11 +3545,6 @@
}
#endif
-#if ENABLE(YARR_JIT_ALL_PARENS_EXPRESSIONS)
- if (m_containsNestedSubpatterns)
- codeBlock.setUsesPaternContextBuffer();
-#endif
-
// We need to compile before generating code since we set flags based on compilation that
// are used during generation.
opCompileBody(m_pattern.m_body);
@@ -3565,6 +3560,11 @@
if (m_disassembler)
m_disassembler->setStartOfCode(label());
+#if ENABLE(YARR_JIT_ALL_PARENS_EXPRESSIONS)
+ if (m_containsNestedSubpatterns)
+ codeBlock.setUsesPaternContextBuffer();
+#endif
+
generateEnter();
Jump hasInput = checkInput();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
