Title: [236706] trunk/Source/WebInspectorUI
Revision
236706
Author
nvasil...@apple.com
Date
2018-10-01 18:37:43 -0700 (Mon, 01 Oct 2018)

Log Message

Web Inspector: Styles: add an experimental setting for multi-property selection
https://bugs.webkit.org/show_bug.cgi?id=190053
<rdar://problem/44842787>

Reviewed by Matt Baker.

This patch only adds a setting. It doesn't change property selection behavior.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Base/Setting.js:
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (236705 => 236706)


--- trunk/Source/WebInspectorUI/ChangeLog	2018-10-02 01:31:37 UTC (rev 236705)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-10-02 01:37:43 UTC (rev 236706)
@@ -1,5 +1,20 @@
 2018-10-01  Nikita Vasilyev  <nvasil...@apple.com>
 
+        Web Inspector: Styles: add an experimental setting for multi-property selection
+        https://bugs.webkit.org/show_bug.cgi?id=190053
+        <rdar://problem/44842787>
+
+        Reviewed by Matt Baker.
+
+        This patch only adds a setting. It doesn't change property selection behavior.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Base/Setting.js:
+        * UserInterface/Views/SettingsTabContentView.js:
+        (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+
+2018-10-01  Nikita Vasilyev  <nvasil...@apple.com>
+
         Web Inspector: Dark Mode: use the same CSS variables for dark and light modes
         https://bugs.webkit.org/show_bug.cgi?id=189766
         <rdar://problem/44619650>

Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (236705 => 236706)


--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2018-10-02 01:31:37 UTC (rev 236705)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2018-10-02 01:37:43 UTC (rev 236706)
@@ -332,6 +332,7 @@
 localizedStrings["Enable Layers Tab"] = "Enable Layers Tab";
 localizedStrings["Enable New Tab Bar"] = "Enable New Tab Bar";
 localizedStrings["Enable Program"] = "Enable Program";
+localizedStrings["Enable Selection of Multiple Properties"] = "Enable Selection of Multiple Properties";
 localizedStrings["Enable all breakpoints (%s)"] = "Enable all breakpoints (%s)";
 localizedStrings["Enable breakpoints"] = "Enable breakpoints";
 localizedStrings["Enable paint flashing"] = "Enable paint flashing";
@@ -823,6 +824,7 @@
 localizedStrings["Styles"] = "Styles";
 localizedStrings["Styles Invalidated"] = "Styles Invalidated";
 localizedStrings["Styles Recalculated"] = "Styles Recalculated";
+localizedStrings["Styles Sidebar:"] = "Styles Sidebar:";
 localizedStrings["Styles \u2014 Computed"] = "Styles \u2014 Computed";
 localizedStrings["Styles \u2014 Rules"] = "Styles \u2014 Rules";
 localizedStrings["Stylesheet"] = "Stylesheet";

Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (236705 => 236706)


--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js	2018-10-02 01:31:37 UTC (rev 236705)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js	2018-10-02 01:37:43 UTC (rev 236706)
@@ -121,6 +121,7 @@
     showAllRequestsBreakpoint: new WI.Setting("show-all-requests-breakpoint", true),
 
     // Experimental
+    experimentalEnableMultiplePropertiesSelection: new WI.Setting("experimental-enable-multiple-properties-selection", false),
     experimentalEnableLayersTab: new WI.Setting("experimental-enable-layers-tab", false),
     experimentalEnableNewTabBar: new WI.Setting("experimental-enable-new-tab-bar", false),
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (236705 => 236706)


--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js	2018-10-02 01:31:37 UTC (rev 236705)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js	2018-10-02 01:37:43 UTC (rev 236706)
@@ -239,6 +239,11 @@
 
         let experimentalSettingsView = new WI.SettingsView("experimental", WI.UIString("Experimental"));
 
+        if (window.CSSAgent) {
+            experimentalSettingsView.addSetting(WI.UIString("Styles Sidebar:"), WI.settings.experimentalEnableMultiplePropertiesSelection, WI.UIString("Enable Selection of Multiple Properties"));
+            experimentalSettingsView.addSeparator();
+        }
+
         if (window.LayerTreeAgent) {
             experimentalSettingsView.addSetting(WI.UIString("Layers:"), WI.settings.experimentalEnableLayersTab, WI.UIString("Enable Layers Tab"));
             experimentalSettingsView.addSeparator();
@@ -261,6 +266,7 @@
             });
         }
 
+        listenForChange(WI.settings.experimentalEnableMultiplePropertiesSelection);
         listenForChange(WI.settings.experimentalEnableLayersTab);
         listenForChange(WI.settings.experimentalEnableNewTabBar);
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to