Title: [236747] trunk/Source/WebCore
Revision
236747
Author
sihui_...@apple.com
Date
2018-10-02 09:46:05 -0700 (Tue, 02 Oct 2018)

Log Message

Add release assertion to ensure m_owningPointerForClose is null in UniqueIDBDatabase::invokeOperationAndTransactionTimer()
https://bugs.webkit.org/show_bug.cgi?id=190178

Reviewed by Chris Dumez.

This would help debug rdar://problem/44902833.

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (236746 => 236747)


--- trunk/Source/WebCore/ChangeLog	2018-10-02 16:15:04 UTC (rev 236746)
+++ trunk/Source/WebCore/ChangeLog	2018-10-02 16:46:05 UTC (rev 236747)
@@ -1,3 +1,15 @@
+2018-10-02  Sihui Liu  <sihui_...@apple.com>
+
+        Add release assertion to ensure m_owningPointerForClose is null in UniqueIDBDatabase::invokeOperationAndTransactionTimer()
+        https://bugs.webkit.org/show_bug.cgi?id=190178
+
+        Reviewed by Chris Dumez.
+
+        This would help debug rdar://problem/44902833.
+
+        * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+        (WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer):
+
 2018-10-02  Commit Queue  <commit-qu...@webkit.org>
 
         Unreviewed, rolling out r236719.

Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (236746 => 236747)


--- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp	2018-10-02 16:15:04 UTC (rev 236746)
+++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp	2018-10-02 16:46:05 UTC (rev 236747)
@@ -1533,8 +1533,8 @@
 void UniqueIDBDatabase::invokeOperationAndTransactionTimer()
 {
     LOG(IndexedDB, "UniqueIDBDatabase::invokeOperationAndTransactionTimer()");
-    ASSERT(!m_hardClosedForUserDelete);
-    ASSERT(!m_owningPointerForClose);
+    RELEASE_ASSERT(!m_hardClosedForUserDelete);
+    RELEASE_ASSERT(!m_owningPointerForClose);
 
     if (!m_operationAndTransactionTimer.isActive())
         m_operationAndTransactionTimer.startOneShot(0_s);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to