Title: [237645] trunk/Source/_javascript_Core
Revision
237645
Author
tzaga...@apple.com
Date
2018-10-31 11:44:11 -0700 (Wed, 31 Oct 2018)

Log Message

Adjust inlining threshold for new bytecode format
https://bugs.webkit.org/show_bug.cgi?id=191115

Reviewed by Saam Barati.

The new format reduced the number of operands for many opcodes, which
changed inlining decisions and impacted performance negatively.

* runtime/Options.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (237644 => 237645)


--- trunk/Source/_javascript_Core/ChangeLog	2018-10-31 18:25:54 UTC (rev 237644)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-10-31 18:44:11 UTC (rev 237645)
@@ -1,5 +1,17 @@
 2018-10-31  Tadeu Zagallo  <tzaga...@apple.com>
 
+        Adjust inlining threshold for new bytecode format
+        https://bugs.webkit.org/show_bug.cgi?id=191115
+
+        Reviewed by Saam Barati.
+
+        The new format reduced the number of operands for many opcodes, which
+        changed inlining decisions and impacted performance negatively.
+
+        * runtime/Options.h:
+
+2018-10-31  Tadeu Zagallo  <tzaga...@apple.com>
+
         REGRESSION(r237547): Exception handlers should be aware of wide opcodes
         https://bugs.webkit.org/show_bug.cgi?id=191108
         <rdar://problem/45690700>

Modified: trunk/Source/_javascript_Core/runtime/Options.h (237644 => 237645)


--- trunk/Source/_javascript_Core/runtime/Options.h	2018-10-31 18:25:54 UTC (rev 237644)
+++ trunk/Source/_javascript_Core/runtime/Options.h	2018-10-31 18:44:11 UTC (rev 237645)
@@ -303,7 +303,7 @@
     \
     v(unsigned, maximumOptimizationCandidateInstructionCount, 100000, Normal, nullptr) \
     \
-    v(unsigned, maximumFunctionForCallInlineCandidateInstructionCount, 190, Normal, nullptr) \
+    v(unsigned, maximumFunctionForCallInlineCandidateInstructionCount, 120, Normal, nullptr) \
     v(unsigned, maximumFunctionForClosureCallInlineCandidateInstructionCount, 100, Normal, nullptr) \
     v(unsigned, maximumFunctionForConstructInlineCandidateInstructionCount, 100, Normal, nullptr) \
     \
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to