Title: [237705] trunk/Source/WebInspectorUI
- Revision
- 237705
- Author
- nvasil...@apple.com
- Date
- 2018-11-01 16:24:16 -0700 (Thu, 01 Nov 2018)
Log Message
Uncaught Exception: TypeError: undefined is not an object (evaluating 'WI.modifierKeys.metaKey') (at ScopeBarItem.js:87:67)
https://bugs.webkit.org/show_bug.cgi?id=191173
Reviewed by Devin Rousso.
WI.modifierKeys was accessed before it was initialized. Move it from WI.contentLoaded to WI.loaded,
which happens before WI.contentLoaded.
* UserInterface/Base/Main.js:
(WI.loaded):
(WI.contentLoaded):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (237704 => 237705)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-11-01 23:22:24 UTC (rev 237704)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-11-01 23:24:16 UTC (rev 237705)
@@ -1,5 +1,19 @@
2018-11-01 Nikita Vasilyev <nvasil...@apple.com>
+ Uncaught Exception: TypeError: undefined is not an object (evaluating 'WI.modifierKeys.metaKey') (at ScopeBarItem.js:87:67)
+ https://bugs.webkit.org/show_bug.cgi?id=191173
+
+ Reviewed by Devin Rousso.
+
+ WI.modifierKeys was accessed before it was initialized. Move it from WI.contentLoaded to WI.loaded,
+ which happens before WI.contentLoaded.
+
+ * UserInterface/Base/Main.js:
+ (WI.loaded):
+ (WI.contentLoaded):
+
+2018-11-01 Nikita Vasilyev <nvasil...@apple.com>
+
REGRESSION(r237652): Web Inspector: dumpInspectorProtocolMessages is always enabled
https://bugs.webkit.org/show_bug.cgi?id=191161
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (237704 => 237705)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2018-11-01 23:22:24 UTC (rev 237704)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2018-11-01 23:24:16 UTC (rev 237705)
@@ -143,6 +143,7 @@
this.printStylesEnabled = false;
this.setZoomFactor(WI.settings.zoomFactor.value);
this.mouseCoords = {x: 0, y: 0};
+ this.modifierKeys = {altKey: false, metaKey: false, shiftKey: false};
this.visible = false;
this._windowKeydownListeners = [];
@@ -386,8 +387,6 @@
this.toolbar.addToolbarItem(this._searchToolbarItem, WI.Toolbar.Section.Right);
}
- this.modifierKeys = {altKey: false, metaKey: false, shiftKey: false};
-
let dockedResizerElement = document.getElementById("docked-resizer");
dockedResizerElement.classList.add(WI.Popover.IgnoreAutoDismissClassName);
dockedResizerElement.addEventListener("mousedown", this._dockedResizerMouseDown.bind(this));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
