Title: [239180] trunk/Source/WebCore
- Revision
- 239180
- Author
- jer.no...@apple.com
- Date
- 2018-12-13 14:32:29 -0800 (Thu, 13 Dec 2018)
Log Message
Fix leak of AVPlayer boundaryTimeObserver object.
https://bugs.webkit.org/show_bug.cgi?id=192674
Reviewed by Eric Carlson.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::performTaskAtMediaTime):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (239179 => 239180)
--- trunk/Source/WebCore/ChangeLog 2018-12-13 22:31:25 UTC (rev 239179)
+++ trunk/Source/WebCore/ChangeLog 2018-12-13 22:32:29 UTC (rev 239180)
@@ -1,3 +1,13 @@
+2018-12-13 Jer Noble <jer.no...@apple.com>
+
+ Fix leak of AVPlayer boundaryTimeObserver object.
+ https://bugs.webkit.org/show_bug.cgi?id=192674
+
+ Reviewed by Eric Carlson.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::performTaskAtMediaTime):
+
2018-12-13 Brent Fulgham <bfulg...@apple.com>
Don't attempt to animate invalid CSS properties
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (239179 => 239180)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2018-12-13 22:31:25 UTC (rev 239179)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2018-12-13 22:32:29 UTC (rev 239180)
@@ -3301,7 +3301,10 @@
__block WTF::Function<void()> taskIn = WTFMove(task);
- [m_avPlayer addBoundaryTimeObserverForTimes:@[[NSValue valueWithCMTime:toCMTime(time)]] queue:dispatch_get_main_queue() usingBlock:^{
+ if (m_timeObserver)
+ [m_avPlayer removeTimeObserver:m_timeObserver.get()];
+
+ m_timeObserver = [m_avPlayer addBoundaryTimeObserverForTimes:@[[NSValue valueWithCMTime:toCMTime(time)]] queue:dispatch_get_main_queue() usingBlock:^{
taskIn();
}];
return true;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
