[webkit-changes] [239616] trunk/Tools

Fri, 04 Jan 2019 10:02:49 -0800

Title: [239616] trunk/Tools
Revision
239616
Author
aakash_j...@apple.com
Date
2019-01-04 10:00:01 -0800 (Fri, 04 Jan 2019)

Log Message

[ews-build] Check patch relevance before applying the patch
https://bugs.webkit.org/show_bug.cgi?id=193102

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/factories.py:
(Factory.__init__): Moved CheckPatchRelevance step to base class.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-build/factories.py (239615 => 239616)


--- trunk/Tools/BuildSlaveSupport/ews-build/factories.py	2019-01-04 17:58:37 UTC (rev 239615)
+++ trunk/Tools/BuildSlaveSupport/ews-build/factories.py	2019-01-04 18:00:01 UTC (rev 239616)
@@ -30,9 +30,11 @@
 
 
 class Factory(factory.BuildFactory):
-    def __init__(self, platform, configuration=None, architectures=None, buildOnly=True, additionalArguments=None, **kwargs):
+    def __init__(self, platform, configuration=None, architectures=None, buildOnly=True, additionalArguments=None, checkRelevance=False, **kwargs):
         factory.BuildFactory.__init__(self)
         self.addStep(ConfigureBuild(platform, configuration, architectures, buildOnly, additionalArguments))
+        if checkRelevance:
+            self.addStep(CheckPatchRelevance())
         self.addStep(CheckOutSource())
 
 
@@ -44,8 +46,7 @@
 
 class BindingsFactory(Factory):
     def __init__(self, platform, configuration=None, architectures=None, additionalArguments=None, **kwargs):
-        Factory.__init__(self, platform, configuration, architectures, False, additionalArguments)
-        self.addStep(CheckPatchRelevance())
+        Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, checkRelevance=True)
         self.addStep(RunBindingsTests())
 
 
@@ -57,8 +58,7 @@
 
 class WebKitPyFactory(Factory):
     def __init__(self, platform, configuration=None, architectures=None, additionalArguments=None, **kwargs):
-        Factory.__init__(self, platform, configuration, architectures, False, additionalArguments)
-        self.addStep(CheckPatchRelevance())
+        Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, checkRelevance=True)
         self.addStep(RunWebKitPyTests())
 
 
@@ -104,8 +104,7 @@
 
 class JSCTestsFactory(Factory):
     def __init__(self, platform, configuration='release', architectures=None, additionalArguments=None, **kwargs):
-        Factory.__init__(self, platform, configuration, architectures, False, additionalArguments)
-        self.addStep(CheckPatchRelevance())
+        Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, checkRelevance=True)
         self.addStep(CompileJSCOnly())
         self.addStep(UnApplyPatchIfRequired())
         self.addStep(CompileJSCOnlyToT())

Modified: trunk/Tools/ChangeLog (239615 => 239616)


--- trunk/Tools/ChangeLog	2019-01-04 17:58:37 UTC (rev 239615)
+++ trunk/Tools/ChangeLog	2019-01-04 18:00:01 UTC (rev 239616)
@@ -1,5 +1,15 @@
 2019-01-04  Aakash Jain  <aakash_j...@apple.com>
 
+        [ews-build] Check patch relevance before applying the patch
+        https://bugs.webkit.org/show_bug.cgi?id=193102
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-build/factories.py:
+        (Factory.__init__): Moved CheckPatchRelevance step to base class.
+
+2019-01-04  Aakash Jain  <aakash_j...@apple.com>
+
         [ews-build] Check patch relevance step should print patch id
         https://bugs.webkit.org/show_bug.cgi?id=193137
 

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to