Title: [239779] trunk/Source
- Revision
- 239779
- Author
- drou...@apple.com
- Date
- 2019-01-09 11:38:45 -0800 (Wed, 09 Jan 2019)
Log Message
Web Inspector: Protocol Logging: log messages as objects if inspector^2 is open
https://bugs.webkit.org/show_bug.cgi?id=193284
Reviewed by Joseph Pecoraro.
Source/WebCore:
No newe tests, as this is simply exposes a value.
* inspector/InspectorFrontendHost.idl:
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::isBeingInspected): Added.
Source/WebInspectorUI:
If inspector^2 is closed, stringify all messages.
If inspector^2 is open, log each message JSON object without modifying it.
* UserInterface/Protocol/LoggingProtocolTracer.js:
(WI.LoggingProtocolTracer.prototype._processEntry):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (239778 => 239779)
--- trunk/Source/WebCore/ChangeLog 2019-01-09 19:05:59 UTC (rev 239778)
+++ trunk/Source/WebCore/ChangeLog 2019-01-09 19:38:45 UTC (rev 239779)
@@ -1,3 +1,17 @@
+2019-01-09 Devin Rousso <drou...@apple.com>
+
+ Web Inspector: Protocol Logging: log messages as objects if inspector^2 is open
+ https://bugs.webkit.org/show_bug.cgi?id=193284
+
+ Reviewed by Joseph Pecoraro.
+
+ No newe tests, as this is simply exposes a value.
+
+ * inspector/InspectorFrontendHost.idl:
+ * inspector/InspectorFrontendHost.h:
+ * inspector/InspectorFrontendHost.cpp:
+ (WebCore::InspectorFrontendHost::isBeingInspected): Added.
+
2019-01-09 Zalan Bujtas <za...@apple.com>
[LFC][BFC][MarginCollapsing] Add support for peculiar cases.
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp (239778 => 239779)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2019-01-09 19:05:59 UTC (rev 239778)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2019-01-09 19:38:45 UTC (rev 239779)
@@ -445,6 +445,15 @@
m_frontendPage->inspectorController().show();
}
+bool InspectorFrontendHost::isBeingInspected()
+{
+ if (!m_frontendPage)
+ return false;
+
+ InspectorController& inspectorController = m_frontendPage->inspectorController();
+ return inspectorController.hasLocalFrontend() || inspectorController.hasRemoteFrontend();
+}
+
bool InspectorFrontendHost::supportsShowCertificate() const
{
#if PLATFORM(COCOA)
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.h (239778 => 239779)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.h 2019-01-09 19:05:59 UTC (rev 239778)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.h 2019-01-09 19:38:45 UTC (rev 239779)
@@ -109,6 +109,7 @@
void beep();
void inspectInspector();
+ bool isBeingInspected();
private:
#if ENABLE(CONTEXT_MENUS)
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.idl (239778 => 239779)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2019-01-09 19:05:59 UTC (rev 239778)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2019-01-09 19:38:45 UTC (rev 239779)
@@ -81,6 +81,7 @@
void beep();
void inspectInspector();
+ boolean isBeingInspected();
};
dictionary ContextMenuItem {
Modified: trunk/Source/WebInspectorUI/ChangeLog (239778 => 239779)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-01-09 19:05:59 UTC (rev 239778)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-01-09 19:38:45 UTC (rev 239779)
@@ -1,3 +1,16 @@
+2019-01-09 Devin Rousso <drou...@apple.com>
+
+ Web Inspector: Protocol Logging: log messages as objects if inspector^2 is open
+ https://bugs.webkit.org/show_bug.cgi?id=193284
+
+ Reviewed by Joseph Pecoraro.
+
+ If inspector^2 is closed, stringify all messages.
+ If inspector^2 is open, log each message JSON object without modifying it.
+
+ * UserInterface/Protocol/LoggingProtocolTracer.js:
+ (WI.LoggingProtocolTracer.prototype._processEntry):
+
2019-01-09 Nikita Vasilyev <nvasil...@apple.com>
Web Inspector: Styles: clicking on property that soon to be discarded shouldn't start selection
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/LoggingProtocolTracer.js (239778 => 239779)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/LoggingProtocolTracer.js 2019-01-09 19:05:59 UTC (rev 239778)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/LoggingProtocolTracer.js 2019-01-09 19:38:45 UTC (rev 239779)
@@ -119,7 +119,13 @@
let targetId = connection && connection.target ? connection.target.identifier : "unknown";
if (this._filterMultiplexingBackend && targetId === "multi")
return;
- this._logToConsole(`${entry.type} (${targetId}): ${JSON.stringify(entry.message)}`);
+
+ let prefix = `${entry.type} (${targetId})`;
+ if (!window.InspectorTest && InspectorFrontendHost.isBeingInspected())
+ this._logToConsole(prefix, entry.message);
+ else
+ this._logToConsole(`${prefix}: ${JSON.stringify(entry.message)}`);
+
if (entry.exception) {
this._logToConsole(entry.exception);
if (entry.exception.stack)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
