Title: [239785] trunk/Tools
- Revision
- 239785
- Author
- aakash_j...@apple.com
- Date
- 2019-01-09 14:24:22 -0800 (Wed, 09 Jan 2019)
Log Message
[ews-build] Add link to bug along with bug title
https://bugs.webkit.org/show_bug.cgi?id=193293
Reviewed by Lucas Forschler.
* BuildSlaveSupport/ews-build/steps.py:
(ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
(ConfigureBuild.add_bug_id_url): Deleted.
(ConfigureBuild.getBugURL): Deleted.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (239784 => 239785)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-01-09 22:08:34 UTC (rev 239784)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-01-09 22:24:22 UTC (rev 239785)
@@ -67,7 +67,6 @@
self.setProperty("additionalArguments", self.additionalArguments, 'config.json')
self.add_patch_id_url()
- self.add_bug_id_url()
self.finished(SUCCESS)
return defer.succeed(None)
@@ -76,22 +75,12 @@
if patch_id:
self.addURL('Patch {}'.format(patch_id), self.getPatchURL(patch_id))
- def add_bug_id_url(self):
- bug_id = self.getProperty('bug_id', '')
- if bug_id:
- self.addURL('Bug {}'.format(bug_id), self.getBugURL(bug_id))
-
def getPatchURL(self, patch_id):
if not patch_id:
return None
return '{}attachment.cgi?id={}'.format(BUG_SERVER_URL, patch_id)
- def getBugURL(self, bug_id):
- if not bug_id:
- return None
- return '{}show_bug.cgi?id={}'.format(BUG_SERVER_URL, bug_id)
-
class CheckOutSource(git.Git):
name = 'clean-and-update-working-directory'
CHECKOUT_DELAY_AND_MAX_RETRIES_PAIR = (0, 2)
@@ -310,6 +299,8 @@
self._addToLog('stdio', 'Unable to fetch bug {}.\n'.format(bug_id))
return -1
+ bug_title = bug_json.get('summary')
+ self.addURL('Bug {} {}'.format(bug_id, bug_title), '{}show_bug.cgi?id={}'.format(BUG_SERVER_URL, bug_id))
if bug_json.get('status') in self.bug_closed_statuses:
return 1
return 0
Modified: trunk/Tools/ChangeLog (239784 => 239785)
--- trunk/Tools/ChangeLog 2019-01-09 22:08:34 UTC (rev 239784)
+++ trunk/Tools/ChangeLog 2019-01-09 22:24:22 UTC (rev 239785)
@@ -1,5 +1,17 @@
2019-01-09 Aakash Jain <aakash_j...@apple.com>
+ [ews-build] Add link to bug along with bug title
+ https://bugs.webkit.org/show_bug.cgi?id=193293
+
+ Reviewed by Lucas Forschler.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
+ (ConfigureBuild.add_bug_id_url): Deleted.
+ (ConfigureBuild.getBugURL): Deleted.
+
+2019-01-09 Aakash Jain <aakash_j...@apple.com>
+
[ews-build] Use https for ews-build server
https://bugs.webkit.org/show_bug.cgi?id=193193
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
