Title: [239848] trunk/Tools
- Revision
- 239848
- Author
- commit-qu...@webkit.org
- Date
- 2019-01-10 15:03:47 -0800 (Thu, 10 Jan 2019)
Log Message
Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
https://bugs.webkit.org/show_bug.cgi?id=193338
<rdar://problem/46664774>
Patch by Joseph Pecoraro <pecor...@apple.com> on 2019-01-10
Reviewed by David Kilzer.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::decidePolicyForNavigationAction):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (239847 => 239848)
--- trunk/Tools/ChangeLog 2019-01-10 22:50:13 UTC (rev 239847)
+++ trunk/Tools/ChangeLog 2019-01-10 23:03:47 UTC (rev 239848)
@@ -1,3 +1,14 @@
+2019-01-10 Joseph Pecoraro <pecor...@apple.com>
+
+ Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
+ https://bugs.webkit.org/show_bug.cgi?id=193338
+ <rdar://problem/46664774>
+
+ Reviewed by David Kilzer.
+
+ * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+ (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
+
2019-01-10 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r239825.
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp (239847 => 239848)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp 2019-01-10 22:50:13 UTC (rev 239847)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp 2019-01-10 23:03:47 UTC (rev 239848)
@@ -1372,10 +1372,11 @@
stringBuilder.appendLiteral(" with navigation type \'");
stringBuilder.append(toWTFString(NavigationTypeToString(WKBundleNavigationActionGetNavigationType(navigationAction))));
stringBuilder.appendLiteral("\'");
- WKBundleHitTestResultRef hitTestResultRef = WKBundleNavigationActionCopyHitTestResult(navigationAction);
+ WKRetainPtr<WKBundleHitTestResultRef> hitTestResultRef = adoptWK(WKBundleNavigationActionCopyHitTestResult(navigationAction));
if (hitTestResultRef) {
+ WKRetainPtr<WKBundleNodeHandleRef> nodeHandleRef = adoptWK(WKBundleHitTestResultCopyNodeHandle(hitTestResultRef.get()));
stringBuilder.appendLiteral(" originating from ");
- stringBuilder.append(dumpPath(m_page, m_world.get(), WKBundleHitTestResultCopyNodeHandle(hitTestResultRef)));
+ stringBuilder.append(dumpPath(m_page, m_world.get(), nodeHandleRef.get()));
}
stringBuilder.append('\n');
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
