Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/models/build.py (240596 => 240597)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/models/build.py 2019-01-28 19:58:19 UTC (rev 240596)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/models/build.py 2019-01-28 20:08:13 UTC (rev 240597)
@@ -1,4 +1,4 @@
-# Copyright (C) 2018 Apple Inc. All rights reserved.
+# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
@@ -28,8 +28,8 @@
class Build(models.Model):
patch = models.ForeignKey(Patch, _on_delete_=models.CASCADE)
- buildid = models.IntegerField(primary_key=True)
- builderid = models.IntegerField()
+ build_id = models.IntegerField(primary_key=True)
+ builder_id = models.IntegerField()
number = models.IntegerField()
result = models.IntegerField(null=True, blank=True)
state_string = models.TextField()
@@ -39,4 +39,4 @@
modified = models.DateTimeField(auto_now=True)
def __str__(self):
- return str(self.buildid)
+ return str(self.build_id)
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py (240596 => 240597)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py 2019-01-28 19:58:19 UTC (rev 240596)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py 2019-01-28 20:08:13 UTC (rev 240597)
@@ -26,8 +26,8 @@
class BuilderMapping(models.Model):
- builderid = models.IntegerField(primary_key=True)
+ builder_id = models.IntegerField(primary_key=True)
name = models.TextField()
def __str__(self):
- return "{}: {}".format(self.builderid, self.name)
+ return "{}: {}".format(self.builder_id, self.name)
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/models/step.py (240596 => 240597)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/models/step.py 2019-01-28 19:58:19 UTC (rev 240596)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/models/step.py 2019-01-28 20:08:13 UTC (rev 240597)
@@ -27,7 +27,7 @@
class Step(models.Model):
- stepid = models.IntegerField(primary_key=True)
+ step_id = models.IntegerField(primary_key=True)
build = models.ForeignKey(Build, _on_delete_=models.CASCADE)
result = models.IntegerField(null=True, blank=True)
state_string = models.TextField()
@@ -37,4 +37,4 @@
modified = models.DateTimeField(auto_now=True)
def __str__(self):
- return str(self.stepid)
+ return str(self.step_id)
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/urls.py (240596 => 240597)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/urls.py 2019-01-28 19:58:19 UTC (rev 240596)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/urls.py 2019-01-28 20:08:13 UTC (rev 240597)
@@ -1,4 +1,4 @@
-# Copyright (C) 2018 Apple Inc. All rights reserved.
+# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
@@ -32,9 +32,9 @@
# ex: /
url(r'^$', Index.as_view(), name='index'),
# ex: /patch/5
- url(r'^patch/(?P<patchid>[0-9]+)/$', Patch.as_view(), name='patch'),
+ url(r'^patch/(?P<patch_id>[0-9]+)/$', Patch.as_view(), name='patch'),
# ex: /patch/5/results
- url(r'^patch/(?P<patchid>[0-9]+)/results$', Results.as_view(), name='results'),
+ url(r'^patch/(?P<patch_id>[0-9]+)/results$', Results.as_view(), name='results'),
# ex: /status-bubble/5
- url(r'^status-bubble/(?P<patchid>[0-9]+)/$', StatusBubble.as_view(), name='statusbubble'),
+ url(r'^status-bubble/(?P<patch_id>[0-9]+)/$', StatusBubble.as_view(), name='statusbubble'),
]
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/patch.py (240596 => 240597)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/patch.py 2019-01-28 19:58:19 UTC (rev 240596)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/patch.py 2019-01-28 20:08:13 UTC (rev 240597)
@@ -1,4 +1,4 @@
-# Copyright (C) 2018 Apple Inc. All rights reserved.
+# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
@@ -28,8 +28,8 @@
class Patch(View):
- def get(self, request, patchid):
- return HttpResponse("Placeholder for patch {}.".format(patchid))
+ def get(self, request, patch_id):
+ return HttpResponse("Placeholder for patch {}.".format(patch_id))
- def post(self, request, patchid):
- return HttpResponse("Placeholder to handle post request for patch {}.".format(patchid))
+ def post(self, request, patch_id):
+ return HttpResponse("Placeholder to handle post request for patch {}.".format(patch_id))
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/results.py (240596 => 240597)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/results.py 2019-01-28 19:58:19 UTC (rev 240596)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/results.py 2019-01-28 20:08:13 UTC (rev 240597)
@@ -1,4 +1,4 @@
-# Copyright (C) 2018 Apple Inc. All rights reserved.
+# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
@@ -28,5 +28,5 @@
class Results(View):
- def post(self, request, patchid):
- return HttpResponse("Placeholder to handle post request for result for patch: {}.".format(patchid))
+ def post(self, request, patch_id):
+ return HttpResponse("Placeholder to handle post request for result for patch: {}.".format(patch_id))
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (240596 => 240597)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-01-28 19:58:19 UTC (rev 240596)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-01-28 20:08:13 UTC (rev 240597)
@@ -1,4 +1,4 @@
-# Copyright (C) 2018 Apple Inc. All rights reserved.
+# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
@@ -28,5 +28,5 @@
class StatusBubble(View):
- def get(self, request, patchid):
- return HttpResponse("Placeholder for status bubble for {}.".format(patchid))
+ def get(self, request, patch_id):
+ return HttpResponse("Placeholder for status bubble for {}.".format(patch_id))
Modified: trunk/Tools/ChangeLog (240596 => 240597)
--- trunk/Tools/ChangeLog 2019-01-28 19:58:19 UTC (rev 240596)
+++ trunk/Tools/ChangeLog 2019-01-28 20:08:13 UTC (rev 240597)
@@ -1,5 +1,20 @@
2019-01-28 Aakash Jain <aakash_j...@apple.com>
+ [ews-app] Rename id variables
+ https://bugs.webkit.org/show_bug.cgi?id=193883
+
+ Reviewed by Lucas Forschler.
+
+ * BuildSlaveSupport/ews-app/ews/models/build.py:
+ * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
+ * BuildSlaveSupport/ews-app/ews/models/step.py:
+ * BuildSlaveSupport/ews-app/ews/urls.py:
+ * BuildSlaveSupport/ews-app/ews/views/patch.py:
+ * BuildSlaveSupport/ews-app/ews/views/results.py:
+ * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+
+2019-01-28 Aakash Jain <aakash_j...@apple.com>
+
[ews-app] Allow certain fields to be empty
https://bugs.webkit.org/show_bug.cgi?id=193892
