Title: [241315] trunk/Source/WebInspectorUI
- Revision
- 241315
- Author
- commit-qu...@webkit.org
- Date
- 2019-02-12 13:21:56 -0800 (Tue, 12 Feb 2019)
Log Message
Web Inspector: Timeline.prototype.recordsInTimeRange uses a property most records do not have
https://bugs.webkit.org/show_bug.cgi?id=194549
Patch by Joseph Pecoraro <pecor...@apple.com> on 2019-02-12
Reviewed by Devin Rousso.
* UserInterface/Models/Timeline.js:
(WI.Timeline.prototype.recordsInTimeRange):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (241314 => 241315)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-02-12 21:17:47 UTC (rev 241314)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-02-12 21:21:56 UTC (rev 241315)
@@ -1,3 +1,13 @@
+2019-02-12 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Timeline.prototype.recordsInTimeRange uses a property most records do not have
+ https://bugs.webkit.org/show_bug.cgi?id=194549
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Models/Timeline.js:
+ (WI.Timeline.prototype.recordsInTimeRange):
+
2019-02-12 Devin Rousso <drou...@apple.com>
Web Inspector: Timelines: clicking on an empty space in the overview should deselect any selected record bar
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Timeline.js (241314 => 241315)
--- trunk/Source/WebInspectorUI/UserInterface/Models/Timeline.js 2019-02-12 21:17:47 UTC (rev 241314)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Timeline.js 2019-02-12 21:21:56 UTC (rev 241315)
@@ -95,8 +95,8 @@
recordsInTimeRange(startTime, endTime, includeRecordBeforeStart)
{
- let lowerIndex = this._records.lowerBound(startTime, (time, record) => time - record.timestamp);
- let upperIndex = this._records.upperBound(endTime, (time, record) => time - record.timestamp);
+ let lowerIndex = this._records.lowerBound(startTime, (time, record) => time - record.startTime);
+ let upperIndex = this._records.upperBound(endTime, (time, record) => time - record.startTime);
// Include the record right before the start time.
if (includeRecordBeforeStart && lowerIndex > 0)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
