Title: [242195] trunk/Source/WebInspectorUI
- Revision
- 242195
- Author
- commit-qu...@webkit.org
- Date
- 2019-02-28 00:07:16 -0800 (Thu, 28 Feb 2019)
Log Message
Web Inspector: Cleanup some Chart code
https://bugs.webkit.org/show_bug.cgi?id=195147
Patch by Joseph Pecoraro <pecor...@apple.com> on 2019-02-28
Reviewed by Matt Baker.
* UserInterface/Views/RangeChart.js:
(WI.RangeChart.prototype.layout):
(WI.RangeChart):
* UserInterface/Views/StackedColumnChart.js:
(WI.StackedColumnChart.prototype.layout):
(WI.StackedColumnChart):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (242194 => 242195)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-02-28 06:54:21 UTC (rev 242194)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-02-28 08:07:16 UTC (rev 242195)
@@ -1,3 +1,17 @@
+2019-02-28 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Cleanup some Chart code
+ https://bugs.webkit.org/show_bug.cgi?id=195147
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/RangeChart.js:
+ (WI.RangeChart.prototype.layout):
+ (WI.RangeChart):
+ * UserInterface/Views/StackedColumnChart.js:
+ (WI.StackedColumnChart.prototype.layout):
+ (WI.StackedColumnChart):
+
2019-02-27 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Add a new Scanner TimelineMarker to show up when mousing over TimelineView graphs
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RangeChart.js (242194 => 242195)
--- trunk/Source/WebInspectorUI/UserInterface/Views/RangeChart.js 2019-02-28 06:54:21 UTC (rev 242194)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RangeChart.js 2019-02-28 08:07:16 UTC (rev 242195)
@@ -98,11 +98,11 @@
this._svgElement.removeChildren();
- let h = 0;
+ let height = this.size.height;
for (let {x, width, className} of this._ranges) {
let rect = this._svgElement.appendChild(createSVGElement("rect"));
rect.setAttribute("width", width);
- rect.setAttribute("height", this.size.height);
+ rect.setAttribute("height", height);
rect.setAttribute("transform", `translate(${x}, 0)`);
rect.classList.add(className);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/StackedColumnChart.js (242194 => 242195)
--- trunk/Source/WebInspectorUI/UserInterface/Views/StackedColumnChart.js 2019-02-28 06:54:21 UTC (rev 242194)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/StackedColumnChart.js 2019-02-28 08:07:16 UTC (rev 242195)
@@ -108,7 +108,6 @@
this._svgElement.removeChildren();
for (let {x, totalHeight, width, heights} of this._columns) {
- let sectionIndex = 0;
for (let i = heights.length - 1; i >= 0; --i) {
let height = heights[i];
// Next rect will be identical, skip this one.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
