Title: [242432] releases/WebKitGTK/webkit-2.24/Source/WebCore
- Revision
- 242432
- Author
- carlo...@webkit.org
- Date
- 2019-03-05 00:44:23 -0800 (Tue, 05 Mar 2019)
Log Message
Merge r241913 - IndexedDB: leak UniqueIDBDatabase in layout tests
https://bugs.webkit.org/show_bug.cgi?id=194870
<rdar://problem/48163812>
Reviewed by Geoffrey Garen.
UniqueIDBDatabase owns a pointer to itself after it is hard closed. It should release the pointer when it
receives confirmation from clients and all pending tasks are done. UniqueIDBDatabase already checks whether the
pointer should be released when a database task finishes, but it didn't perform a check when a confirm message
is received.
No new test as the order of task completion and confirmation arrival is uncertain.
* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::confirmDidCloseFromServer):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog (242431 => 242432)
--- releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog 2019-03-05 08:44:19 UTC (rev 242431)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog 2019-03-05 08:44:23 UTC (rev 242432)
@@ -1,3 +1,21 @@
+2019-02-21 Sihui Liu <sihui_...@apple.com>
+
+ IndexedDB: leak UniqueIDBDatabase in layout tests
+ https://bugs.webkit.org/show_bug.cgi?id=194870
+ <rdar://problem/48163812>
+
+ Reviewed by Geoffrey Garen.
+
+ UniqueIDBDatabase owns a pointer to itself after it is hard closed. It should release the pointer when it
+ receives confirmation from clients and all pending tasks are done. UniqueIDBDatabase already checks whether the
+ pointer should be released when a database task finishes, but it didn't perform a check when a confirm message
+ is received.
+
+ No new test as the order of task completion and confirmation arrival is uncertain.
+
+ * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+ (WebCore::IDBServer::UniqueIDBDatabase::confirmDidCloseFromServer):
+
2019-02-21 Rob Buis <rb...@igalia.com>
Update MIME type parser
Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (242431 => 242432)
--- releases/WebKitGTK/webkit-2.24/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2019-03-05 08:44:19 UTC (rev 242431)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2019-03-05 08:44:23 UTC (rev 242432)
@@ -1519,6 +1519,8 @@
ASSERT(isMainThread());
LOG(IndexedDB, "UniqueIDBDatabase::confirmDidCloseFromServer - %s (%" PRIu64 ")", connection.openRequestIdentifier().loggingString().utf8().data(), connection.identifier());
+ if (m_hardClosedForUserDelete)
+ maybeFinishHardClose();
ASSERT(m_serverClosePendingDatabaseConnections.contains(&connection));
m_serverClosePendingDatabaseConnections.remove(&connection);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
