Title: [242880] trunk/Tools
- Revision
- 242880
- Author
- aakash_j...@apple.com
- Date
- 2019-03-13 04:27:08 -0700 (Wed, 13 Mar 2019)
Log Message
[ews-app] status bubble should be hidden for certain builds
https://bugs.webkit.org/show_bug.cgi?id=194597
Reviewed by Dewei Zhu.
* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubble):
(StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
because the patch didn't have relevant changes.
(StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
in production yet.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (242879 => 242880)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-03-13 09:47:59 UTC (rev 242879)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-03-13 11:27:08 UTC (rev 242880)
@@ -22,6 +22,8 @@
from __future__ import unicode_literals
+import re
+
from django.http import HttpResponse
from django.shortcuts import render
from django.views import View
@@ -42,6 +44,9 @@
"name": queue,
}
build = self.get_latest_build_for_queue(patch, queue)
+ if not self._should_show_bubble_for_build(build):
+ return None
+
if not build:
bubble["state"] = "none"
bubble["details_message"] = 'Waiting in queue, processing has not started yet.'
@@ -79,8 +84,12 @@
def get_builds_for_queue(self, patch, queue):
return [build for build in patch.build_set.all() if build.builder_display_name == queue]
- def _should_show_bubble_for(self, patch, queue):
- # TODO: https://bugs.webkit.org/show_bug.cgi?id=194597
+ def _should_show_bubble_for_build(self, build):
+ if build and build.result == 3 and re.search(r'Patch .* doesn\'t have relevant changes', build.state_string):
+ return False
+ return True
+
+ def _should_show_bubble_for_queue(self, queue):
return queue in StatusBubble.ENABLED_QUEUES
def _build_bubbles_for_patch(self, patch):
@@ -92,7 +101,7 @@
return (None, show_submit_to_ews, failed_to_apply)
for queue in StatusBubble.ALL_QUEUES:
- if not self._should_show_bubble_for(patch, queue):
+ if not self._should_show_bubble_for_queue(queue):
continue
bubble = self._build_bubble(patch, queue)
Modified: trunk/Tools/ChangeLog (242879 => 242880)
--- trunk/Tools/ChangeLog 2019-03-13 09:47:59 UTC (rev 242879)
+++ trunk/Tools/ChangeLog 2019-03-13 11:27:08 UTC (rev 242880)
@@ -1,3 +1,17 @@
+2019-03-13 Aakash Jain <aakash_j...@apple.com>
+
+ [ews-app] status bubble should be hidden for certain builds
+ https://bugs.webkit.org/show_bug.cgi?id=194597
+
+ Reviewed by Dewei Zhu.
+
+ * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+ (StatusBubble._build_bubble):
+ (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
+ because the patch didn't have relevant changes.
+ (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
+ in production yet.
+
2019-03-12 Ross Kirsling <ross.kirsl...@sony.com>
[Win] Fix a slew of simple clang-cl warnings.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
